Opened 3 years ago

Last modified 8 months ago

#13174 assigned enhancement

[CodyCam] fix incorrect use of Layout API (easy)

Reported by: diver Owned by: humdinger
Priority: normal Milestone: Unscheduled
Component: Applications/CodyCam Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by diver)

Attachments (1)

codycam.png (55.3 KB ) - added by diver 3 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 by CodeforEvolution, 3 years ago

I looked in CodyCam's code and it seems to already be using the layout API, or did I accidentally miss a section of code?

Last edited 3 years ago by CodeforEvolution (previous) (diff)

comment:2 by diver, 3 years ago

Hmm, this is odd. I can't reproduce GUI problems (overlapping) in vmware with 24pt. font but it looks messed up on real hw with HiDPI. The same with #13164 and #13166. The only difference is resolution.

comment:3 by CodeforEvolution, 3 years ago

In that case, I'd assume it must be a general problem with sizing when using HiDPI displays. In that case, support for HiDPI is going to have to be implemented in some form eventually...

comment:4 by diver, 3 years ago

Description: modified (diff)

by diver, 3 years ago

Attachment: codycam.png added

comment:5 by diver, 3 years ago

Owner: changed from mmu_man to humdinger
Status: newassigned

comment:6 by diver, 3 years ago

Description: modified (diff)

comment:7 by axeld, 3 years ago

CodyCam is using the layout API, but it is using it incorrectly; the BBox comes with its own layout that makes sure the label is taken into account. However, the code sets a new layout on the BBox, causing the issue -- it uses a hard coded top offset that hides this bug in the 'normal' font size case.

comment:8 by pulkomandy, 3 years ago

And the fix, if anyone wants to tackle it, is to add an extra BView as the BBox only children, add the grid layout to that, and add the children there.

comment:9 by pulkomandy, 3 years ago

Summary: [CodyCam] rewrite to use Layout API[CodyCam] fix incorrect use of Layout API (easy)

comment:10 by diver, 3 years ago

Does hrev50853 also fix Video source view alignment?

comment:11 by humdinger, 3 years ago

Not sure what exactly you mean. The top box that's supposed to show the video source is centered horizontally in the window. It keeps centered when resizing the window.

comment:12 by diver, 3 years ago

Shouldn't it spread horizontally across the window or its geometry supposed to be like that?

comment:13 by humdinger, 3 years ago

I guess we'll only know if we get support for a real video source... if it can stretch, we can re-enable vertical resizing and scale the video box. Until then it's fixed size and aspect.

comment:14 by pulkomandy, 3 years ago

The video view should rescale when it manages to find a video source. You need one of the working "sonix" webcams, or I can send you a patched UVC driver, which somewhat works (shows only a black area for me, but at least it detects the webcam) for testing.

comment:15 by humdinger, 3 years ago

Sure PulkoMandy, I can give it a try. Maybe upload it somewhere.

comment:16 by Naba7, 8 months ago

I am taking up this issue.I am participating in OUTREACHY. Cc: Naba7

Note: See TracTickets for help on using tickets.