Opened 8 years ago
Closed 10 months ago
#13174 closed enhancement (fixed)
[CodyCam] fix incorrect use of Layout API (easy)
Reported by: | diver | Owned by: | humdinger |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Applications/CodyCam | Version: | R1/Development |
Keywords: | hidpi | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description (last modified by )
Attachments (1)
Change History (21)
comment:2 by , 8 years ago
comment:3 by , 8 years ago
In that case, I'd assume it must be a general problem with sizing when using HiDPI displays. In that case, support for HiDPI is going to have to be implemented in some form eventually...
comment:4 by , 8 years ago
Description: | modified (diff) |
---|
by , 8 years ago
Attachment: | codycam.png added |
---|
comment:5 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 8 years ago
Description: | modified (diff) |
---|
comment:7 by , 8 years ago
CodyCam is using the layout API, but it is using it incorrectly; the BBox comes with its own layout that makes sure the label is taken into account. However, the code sets a new layout on the BBox, causing the issue -- it uses a hard coded top offset that hides this bug in the 'normal' font size case.
comment:8 by , 8 years ago
And the fix, if anyone wants to tackle it, is to add an extra BView as the BBox only children, add the grid layout to that, and add the children there.
comment:9 by , 8 years ago
Summary: | [CodyCam] rewrite to use Layout API → [CodyCam] fix incorrect use of Layout API (easy) |
---|
comment:11 by , 8 years ago
Not sure what exactly you mean. The top box that's supposed to show the video source is centered horizontally in the window. It keeps centered when resizing the window.
comment:12 by , 8 years ago
Shouldn't it spread horizontally across the window or its geometry supposed to be like that?
comment:13 by , 8 years ago
I guess we'll only know if we get support for a real video source... if it can stretch, we can re-enable vertical resizing and scale the video box. Until then it's fixed size and aspect.
comment:14 by , 8 years ago
The video view should rescale when it manages to find a video source. You need one of the working "sonix" webcams, or I can send you a patched UVC driver, which somewhat works (shows only a black area for me, but at least it detects the webcam) for testing.
comment:17 by , 5 years ago
Hi, I would like to work on this issue, I'm new to Haiku so i might need some guidance.
comment:18 by , 5 years ago
Let us know what you need help with. It may be a good idea to join the IRC channel (#haiku on freenode) for realtime chat, see https://www.haiku-os.org/community/irc
comment:19 by , 5 years ago
Keywords: | hidpi added |
---|
comment:20 by , 10 months ago
Milestone: | Unscheduled |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
This was fixed in 2017 by humdinger.
https://cgit.haiku-os.org/haiku/commit/?id=a325242d7fc7445971c844afd013df375ad64e7f
I looked in CodyCam's code and it seems to already be using the layout API, or did I accidentally miss a section of code?