Opened 3 years ago

Last modified 5 weeks ago

#13222 assigned enhancement

[Tracker] use 32x32 icons with font size >= 18pt.

Reported by: diver Owned by: jscipione
Priority: normal Milestone: Unscheduled
Component: Applications/Tracker Version: R1/Development
Keywords: hidpi Cc: axeld
Blocked By: Blocking:
Platform: All


Attachments (2)

tracker.patch (2.2 KB ) - added by diver 3 years ago.
proof of concept patch
tracker_v2.patch (5.7 KB ) - added by anevilyak 3 years ago.
Updated version of patch

Download all attachments as: .zip

Change History (8)

by diver, 3 years ago

Attachment: tracker.patch added

proof of concept patch

by anevilyak, 3 years ago

Attachment: tracker_v2.patch added

Updated version of patch

comment:1 by anevilyak, 3 years ago

patch: 01

comment:2 by anevilyak, 3 years ago

Cc: axeld added

Attached an updated version of the original patch, which modifies the two menu item classes to dynamically calculate their spacing based on an icon_which instead of hardcoding various constants. As far as making this switchable completely on the fly though, a few complications remain. The first question is whether a simple "font size > 18.0" heuristic is good enough for deciding between the smaller vs larger icon size, and also, there may be other places in Tracker that need some adjustments to take that into account, as IconMenuItem allows one to pass in an icon_size, which might be getting used elsewhere in libtracker.

In the long term, it'd be nice to rewrite this entirely to use HVIF to get an icon that's a more precise match for the font size, but that'd involve significant changes to the icon cache and various other pieces.

comment:3 by jscipione, 2 years ago

Owner: changed from anevilyak to jscipione
Status: newassigned

comment:4 by waddlesplash, 20 months ago

Following hrev52496 I'm not quite sure what relevance this patch still has, so -- axeld, what should be done here after your change?

comment:5 by luroh, 20 months ago

Type: bugenhancement

comment:6 by diver, 5 weeks ago

Keywords: hidpi added
Note: See TracTickets for help on using tickets.