Opened 8 years ago
Closed 2 years ago
#13222 closed enhancement (fixed)
[Tracker] use 32x32 icons with font size >= 18pt.
Reported by: | diver | Owned by: | jscipione |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Applications/Tracker | Version: | R1/Development |
Keywords: | hidpi | Cc: | axeld |
Blocked By: | Blocking: | ||
Platform: | All |
Description
Attachments (2)
Change History (9)
by , 8 years ago
Attachment: | tracker.patch added |
---|
comment:1 by , 8 years ago
patch: | 0 → 1 |
---|
comment:2 by , 8 years ago
Cc: | added |
---|
Attached an updated version of the original patch, which modifies the two menu item classes to dynamically calculate their spacing based on an icon_which instead of hardcoding various constants. As far as making this switchable completely on the fly though, a few complications remain. The first question is whether a simple "font size > 18.0" heuristic is good enough for deciding between the smaller vs larger icon size, and also, there may be other places in Tracker that need some adjustments to take that into account, as IconMenuItem allows one to pass in an icon_size, which might be getting used elsewhere in libtracker.
In the long term, it'd be nice to rewrite this entirely to use HVIF to get an icon that's a more precise match for the font size, but that'd involve significant changes to the icon cache and various other pieces.
comment:3 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 6 years ago
Following hrev52496 I'm not quite sure what relevance this patch still has, so -- axeld, what should be done here after your change?
comment:5 by , 6 years ago
Type: | bug → enhancement |
---|
comment:6 by , 4 years ago
Keywords: | hidpi added |
---|
comment:7 by , 2 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed in hrev52496 (a while back)
proof of concept patch