Opened 8 years ago
Closed 8 years ago
#13282 closed enhancement (fixed)
Localize package daemon and solver
Reported by: | humdinger | Owned by: | pulkomandy |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Kits/Package Kit | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
This is hrev50931.
The dialog popping up when installing a package or if there are problems when installing a package, isn't yet localized. Attached is a patch for that as far as I've come (with a little help of AHelpfulYak)...
It's not completely working, I suspect the Jamfile for the solver isn't quite OK. Can I just invent a target and signature for the DoCatalogs?
I'll assign to PulkoMandy as our localization expert, but any help is welcome...
Attachments (3)
Change History (10)
by , 8 years ago
Attachment: | 0001-Add-localization-to-package-daemon-and-solver.patch added |
---|
comment:1 by , 8 years ago
patch: | 0 → 1 |
---|
comment:2 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 8 years ago
For things to work:
- The library must have a MIME type. IIRC you can add it the usual way, with an rdef file. Example for libbe: http://cgit.haiku-os.org/haiku/tree/src/kits/libbe_version.rdef , http://cgit.haiku-os.org/haiku/tree/src/kits/Jamfile#n30
- The catalogs must match that MIME type.
- The locale stub must be linked into the library (you did this already).
And that should be enough. libbe is a special case, it uses a special "gSystemCatalog" (for example in BColorControl). I don't know if localization of shared libraries has been tested before outside of libbe case?
comment:4 by , 8 years ago
Thanks, pulkomandy. Not sure I got it right... see the updated patch.
Jamming the solver fails with:
../../../../generated/objects/haiku/x86_gcc2/release/kits/package/SolverProblem.o: In function `BPackageKit::BSolverProblem::ToString(void) const': SolverProblem.cpp:(.text+0x454): undefined reference to `BLocaleRoster::GetCatalog(void)' ../../../../generated/objects/haiku/x86_gcc2/release/kits/package/SolverProblemSolution.o: In function `BPackageKit::BSolverProblemSolutionElement::ToString(void) const': SolverProblemSolution.cpp:(.text+0x1e8): undefined reference to `BLocaleRoster::GetCatalog(void)' collect2: ld returned 1 exit status
by , 8 years ago
Attachment: | 0002-Add-localization-to-package-daemon-and-solver.patch added |
---|
updated patch
comment:5 by , 8 years ago
I don't see any changes to http://cgit.haiku-os.org/haiku/tree/src/kits/package/Jamfile in your patch. This is where libpackage is linked, and where the rdef and locale stub should be added?
comment:6 by , 8 years ago
The rest of the 0002 patch was OK? I'm flying blind here... With the 0003 patch I now added "localestub" and the adding of the rdef also to src/kits/package/Jamfile. It does compile now, but I don't know if it's correct and actually works. If you want to, apply the patch and add any further changes yourself. Otherwise we may be doing a few more rounds, I fear. :)
by , 8 years ago
Attachment: | 0003-Add-localization-to-package-daemon-and-solver.patch added |
---|
updated patch
comment:7 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Applied a slightly improved patch with hrev50949.
localization patch