Opened 8 years ago
Closed 7 years ago
#13470 closed bug (fixed)
B_BEOS_DATA_DIRECTORY Shouldn't Exist
Reported by: | AGMS | Owned by: | nobody |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Kits/Storage Kit | Version: | R1/Development |
Keywords: | finddir finddirectory | Cc: | agmsmith@… |
Blocked By: | Blocking: | ||
Platform: | All |
Description
B_BEOS_DATA_DIRECTORY is a Haiku invention, it doesn't exist in BeOS R5.
So, please remove it from headers/os/storage/FindDirectory.h and related places.
It's pretty safe to remove since it doesn't change the enum ordering (it's actually an aliasing to another enum label).
Attachments (1)
Change History (14)
by , 8 years ago
Attachment: | 0001-Remove-Spurious-B_BEOS_DATA_DIRECTORY.patch added |
---|
comment:1 by , 8 years ago
patch: | 0 → 1 |
---|
comment:2 by , 8 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
Your summary is a bit misleading: B_BEOS_DATA_DIRECTORY
is a *deprecated* Haiku invention, that can now be removed :-)
comment:5 by , 8 years ago
A Google search reveals at least one application still using it, but it is my own code and I will happily fix it.
comment:6 by , 7 years ago
How about just changing the documentation to say that the symbol history goes back to Haiku, not to BeOS?
follow-up: 8 comment:7 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Applied in hrev51155, thanks!
comment:8 by , 7 years ago
comment:9 by , 7 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Is there a bug report system for meta-bugs? This bug report causes processing glitches in the programmers :-)
comment:11 by , 7 years ago
Oops, didn't see that other commit before hrev51155. Sorry about that, feel free to close this bug.
Argh, I too have been hit by the programmer processing problem caused by this bug! :-)
comment:12 by , 7 years ago
This is probably not the appropriate place to issue a warning, but I have a serious concern about hrev51155. After updating both my x86_64 and x86_gcc5h partitions, now neither will boot - it only gets to the rocket icon.
comment:13 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Patch for removing the symbol and updating the documentation.