Opened 7 years ago

Last modified 7 years ago

#13522 closed bug

BNetworkAddress::SetTo() doesn't store some error cases. — at Version 1

Reported by: anevilyak Owned by: pulkomandy
Priority: normal Milestone: Unscheduled
Component: Kits/Network Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description (last modified by anevilyak)

In several of BNetworkAddress's SetTo variants, there are error conditions that are returned, but not stored on fStatus. Consequently, if the address was set via the constructor, these errors may go undetected by subsequent calls to InitCheck().

For instance, at http://cgit.haiku-os.org/haiku/tree/src/kits/network/libnetapi/NetworkAddress.cpp#n165

If either Resolver.Get() or Resolver->InitCheck() fail, the result is not stored on fStatus.

Since the above example is consistent across every SetTo() that requires the use of the resolver, I was uncertain if the behavior was deliberate for that case, and thought it best to report it.

Change History (1)

comment:1 by anevilyak, 7 years ago

Description: modified (diff)
Owner: changed from nobody to pulkomandy
Status: newassigned
Note: See TracTickets for help on using tickets.