Opened 7 years ago
Closed 7 years ago
#13526 closed bug (fixed)
BFont::Blocks doesn't work properly
| Reported by: | dsizzle | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | - General | Version: | R1/Development |
| Keywords: | BFont, Blocks, unicode | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Attachments (2)
Change History (8)
by , 7 years ago
| Attachment: | 0002-Fixes-13526-so-that-BFont-Blocks-properly-set-bitmas.patch added |
|---|
comment:1 by , 7 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Reopening as I found another critical issue. The fStyle parameter wasn't being unlocked so future calls to GetTransformedFace would hang. Also fontconfig charsets were being leaked. Addressed in latest patch.
by , 7 years ago
| Attachment: | 0001-Critical-cleanup-code-for-GetUnicodeBlocks-and-Inclu.patch added |
|---|
Patch to fix critical lock issue and memory leaks
comment:4 by , 7 years ago
Regarding unit tests for the hrev51176 fixes, that's non-trivial but I will see if I can figure out a reasonable way to write some.
comment:6 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Applied in hrev51244. Sorry for the delay. Still no unit tests? :)
Note:
See TracTickets
for help on using tickets.
Applied in hrev51176. Unit tests for the fixed problems would be welcome.