Opened 7 years ago

Closed 7 years ago

#13568 closed bug (fixed)

Compilation error on u-boot loader when compiling Haiku for ARM platform

Reported by: pemdp Owned by: jessicah
Priority: normal Milestone: Unscheduled
Component: System/Boot Loader Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: arm

Description

Compiling Haiku for ARM results in a compilation error (no matching function for call to) on the function platform_get_boot_partitions() of u-boot/devices.cpp. On that function a partition is being added to a NodeList, however it seems that Partition class is not properly defined. The problem may be related with a missing include (partitions.h). Please check the patch in attach.

To reproduce the issue you can run the following command: 

../configure --build-cross-tools arm ../../buildtools/
jam -q -sHAIKU_BOOT_BOARD=verdex -sHAIKU_BOOTSTRAP_BUILD=1 haiku-mmc-image haiku-flash-uimage

This was verified on a machine running Linux Ubuntu 16.04.

Attachments (1)

0001-Add-missing-include-with-Partition-class-definition.patch​ (822 bytes ) - added by pemdp 7 years ago.

Download all attachments as: .zip

Change History (6)

by pemdp, 7 years ago

Attachment: 0001-Add-missing-include-with-Partition-class-definition.patch​ added

comment:1 by pemdp, 7 years ago

patch: 0 → 1

comment:2 by waddlesplash, 7 years ago

Patch LGTM.

comment:4 by pulkomandy, 7 years ago

Owner: changed from nobody to jessicah
Status: new → assigned

Patch looks similar to f286626cd, which fixed the same problem for BIOS platforms after some UEFI changes. Sounds good.

comment:5 by waddlesplash, 7 years ago

Resolution: → fixed
Status: assigned → closed

Applied in hrev51214. Thanks!

Note: See TracTickets for help on using tickets.