Opened 2 years ago

Closed 2 years ago

#13611 closed enhancement (fixed)

[PATCH] Fix window behavior when default button is present

Reported by: KapiX Owned by: axeld
Priority: normal Milestone: Unscheduled
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Currently the window hijacks almost all Enter key combos. Add/RemoveShortcut don't work for Enter in apps.

Attached is a patch that limits captures combos to Enter without modifiers.

Attachments (1)

0001-Fix-window-behavior-if-default-button-is-present.patch (1.2 KB ) - added by KapiX 2 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by KapiX, 2 years ago

Has a Patch: set

comment:2 by axeld, 2 years ago

Looks good, thanks. There are two minor style issues, though, that I would appreciate if you could fix them:

  • constants should get the 'k' prefix. The name should then probably be improved to kAnyModifier.
  • We prefer == 0 instead of !:

(modifiers() & modifierKeys) == 0

comment:3 by axeld, 2 years ago

Looks great now, thank you!

comment:4 by axeld, 2 years ago

Owner: changed from nobody to axeld
Status: newin-progress

comment:5 by axeld, 2 years ago

Resolution: fixed
Status: in-progressclosed

Applied in hrev51292, thanks!

Note: See TracTickets for help on using tickets.