SoftwareUpdater: error after update

[Giova84]

Updating from hrev51278_gcc2h to 51291_gcc2h using SoftwareUpdater (from a Terminal window); after packages downloading and installing, I got:

ERROR - you must Lock a looper before calling Quit(), team=1857, looper=w>SoftwareUpdater

However the update process went fine.

[diver]

Do you have debug report for this crash?

[axeld]

Looking for Quit() in the sources reveal the following in ​http://cgit.haiku-os.org/haiku/tree/src/apps/softwareupdater/UpdateManager.cpp#n59 UpdateManager.cpp:

UpdateManager::~UpdateManager()
{
	if (fStatusWindow != NULL)
		fStatusWindow->Quit();
	if (fProblemWindow != NULL)
		fProblemWindow->Quit();
}

[Giova84]

Replying to diver:

Do you have debug report for this crash?

When it shows this error message (from the Terminal), unfortunately SoftwareUpdater doesn't show any error/debug window (the one which asks to save a debug report); in facts seems that this error is only displayed if I run SoftwareUpdater from the Terminal.

[perelandra]

Ah yes I may need to add a call to Lock() in there, I recently changed the way the app quits when i enabled the tab close box.

[perelandra]

Fix tested and is coming in the next version.

[perelandra]

Fixed in hrev51325