Opened 2 years ago

Closed 2 years ago

#13689 closed enhancement (fixed)

BCalendarView: Fix issues with displaying locale based day name header.

Reported by: akshay Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

  • Use BDateFormat::GetDayName() to fetch weekday names.
  • Use appropriate symbol width(Mon, Mo, M) depending on the frame width.
  • Provide functionality to update day name header in case of locale preferences change.

Attachments (4)

0001-BCalendarView-Fix-displaying-locale-based-day-name-h.patch (2.8 KB ) - added by akshay 2 years ago.
0001-Time-Preferences-Update-CalendarView-day-name-header.patch (2.3 KB ) - added by akshay 2 years ago.
Time Preferences: update day name header in calendar view on locale preferences change.
0001-Properly-map-day-values-to-ICU-day-of-week.patch (713 bytes ) - added by akshay 2 years ago.
0001-BDateFormat-Properly-map-day-values-to-ICU-day-of-we.patch (1.3 KB ) - added by akshay 2 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by akshay, 2 years ago

Has a Patch: set

by akshay, 2 years ago

Time Preferences: update day name header in calendar view on locale preferences change.

comment:2 by pulkomandy, 2 years ago

For clarity, I would make a dedicated function for this. As it is now, reading the code, people will wonder what this line is doing. If you move it into a separate inline function then it becomes clear what's the purpose. Something like convertDayNumberToICU or so.

comment:3 by pulkomandy, 2 years ago

Resolution: fixed
Status: newclosed

Applied remaining changes in hrev51428.

Note: See TracTickets for help on using tickets.