Opened 19 months ago

Closed 8 months ago

#13730 closed bug (fixed)

BOutlineListView::EachItemUnder gets too many items

Reported by: jalopeura Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

EachItemUnder selects items that are not in fact under the superitem passed to the method.

Attachments (2)

OutlineListView_EachItemUnder.cpp (1.3 KB) - added by jalopeura 19 months ago.
Simple program to reproduce the bug
OutlineListView_EachItemUnder.diff (660 bytes) - added by jalopeura 19 months ago.

Download all attachments as: .zip

Change History (7)

Changed 19 months ago by jalopeura

Simple program to reproduce the bug

comment:1 Changed 19 months ago by jalopeura

Has a Patch: set

Changed 19 months ago by jalopeura

comment:2 Changed 18 months ago by pulkomandy

The new implementation also excludes the SuperItem itself. This probably makes sense, but is there an undocumented BeOS quirk here?

Also, it seems strange that the function starts with an IndexOf but then use that index to access FullList* functions. I think that's a bug and FullListIndexOf should be used instead?

comment:3 Changed 15 months ago by pulkomandy

Migrated patch to Gerrit: https://review.haiku-os.org/52

comment:4 Changed 15 months ago by pulkomandy

Has a Patch: unset

comment:5 Changed 8 months ago by waddlesplash

Resolution: fixed
Status: newclosed

Merged in hrev52210.

Note: See TracTickets for help on using tickets.