BListView Selection Boxes not Updated

[AGMS]

If you change a BListView's items (custom BListItems) to have different sizes (in this case it was changing a font size, making the items taller or shorter), and call Update() on all of the items to set the new width and height (the custom Update does a SetWidth() and a SetHeight()), the items get drawn with the new size but the selection rectangles for each item don't get updated (so the selection highlights are all for the previous size, and the mouse clicks are similarly off).

In BeOS it works if you call the BListView's Invalidate() function.

I got it to work in all Haiku versions by adding a dummy list item at the top of the list and then deleting it (a do-nothing FrameResized() call worked only in more recent Haiku).

So, I suggest calling the private function that updates the selection rectangles (_UpdateItems() or _RecalcItemTops()?) in the general Invalidate() call. Or maybe make it a separate function. Or should the BListItem Update() be a virtual function that does some housekeeping?

[AGMS]

Patch to BListView::Invalidate() to also update the list items' cached selection boxes.

[AGMS]

That patch to BListView::Invalidate() is a bit of a hack since Invalidate() isn't a virtual function. Anyone got a better suggestion for wedging something into Invalidate()?

[AGMS]

Documentation change describing work-arounds for BListItem::SetHeight() not updating the selection boxes in the BListView.

[AGMS]

Rather than changing the code to fix the selection box caching problem, here's a second patch that just updates the documentation with a warning and work-around.

[waddlesplash]

I wonder: Instead of either of the solutions proposed here, perhaps we could have the BListItem call _RecalcItemTops(0) when the size changes and remove the need to call Invalidate? Because that seems much cleaner than the solutions proposed thus far.

[AGMS]

Unfortunately the BListItem doesn't know which BListView it is inside of. So it can't call _RecalcItemTops. Also can't override SetHeight(), it's not virtual. Pity.

[AGMS]

I think the documentation update would be enough.

[pulkomandy]

Patch migrated to Gerrit: ​https://review.haiku-os.org/45

[AGMS]

Documentation fix is in hrev51796.

[cocobean]

@AGMS - Resolved?

[AGMS]

Still a problem as of April 2019, but you could say it was resolved by documentation.

[nielx]

Remove milestone for tickets with status = closed and resolution != fixed