Opened 2 years ago

Closed 20 months ago

#13775 closed bug (fixed)

readcd clone option causes Haiku to KDL

Reported by: vidrep Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Drivers/Disk/ATA Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by diver)

hrev51543 x86_64

Mount CDROM

readcd dev=10,1,0 -clone f=clone

-clone option causes Haiku to KDL 100% of the time

Attachments (4)

readcd.png (18.4 KB ) - added by vidrep 2 years ago.
syslog (131.2 KB ) - added by vidrep 2 years ago.
readcd_KDL.JPG (1.4 MB ) - added by vidrep 2 years ago.
syslog.2 (16.6 KB ) - added by vidrep 20 months ago.

Download all attachments as: .zip

Change History (15)

by vidrep, 2 years ago

Attachment: readcd.png added

comment:1 by vidrep, 2 years ago

Has a Patch: set

by vidrep, 2 years ago

Attachment: syslog added

by vidrep, 2 years ago

Attachment: readcd_KDL.JPG added

comment:2 by waddlesplash, 2 years ago

Component: - GeneralDrivers/Disk/ATA

comment:3 by vidrep, 2 years ago

Also KDL's on x86_gcc2h. Change platform to "All".

comment:4 by vidrep, 2 years ago

Platform: x86-64All

comment:5 by korli, 2 years ago

Has a Patch: unset

comment:6 by diver, 2 years ago

Description: modified (diff)

comment:7 by vidrep, 20 months ago

Still an issue. Tested with hrev51846 x86_gcc2h, using thew following command:

readcd dev=10,1,0 -clone -nocorr -retries=0 f=clone

Haiku KDL immediately. syslog attached

by vidrep, 20 months ago

Attachment: syslog.2 added

comment:8 by korli, 20 months ago

Hi, readcd seems to send a command with a zero datalength, which is unusual: https://github.com/jobermayr/cdrtools/blob/master/readcd/readcd.c#L1034

It seems though this case should be supported by avoiding DMA when no SG list is provided. https://git.haiku-os.org/haiku/tree/src/add-ons/kernel/bus_managers/ata/ATAPIDevice.cpp#n38

comment:9 by korli, 20 months ago

Please test with hrev51851, hopefully it helps.

comment:10 by vidrep, 20 months ago

Works now! Close the ticket please. Thanks korli.

comment:11 by korli, 20 months ago

Resolution: fixed
Status: newclosed

Thanks for the feedback!

Note: See TracTickets for help on using tickets.