Opened 17 months ago

Closed 2 months ago

#13786 closed bug (fixed)

[Repositories] ignores repos not starting with http://

Reported by: diver Owned by: perelandra
Priority: normal Milestone: Unscheduled
Component: Preferences/Repositories Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by diver)

I've overwrote haikuporter repo with buildmaster to my x86_gcc2 Haiku running hrev51555

pkgman add eu.hpkg.haiku-os.org/haikuports/master/repository/x86_gcc2/current

For some reason Repositories doesn't list buildmaster repo at all.

Attachments (1)

Repositories.png (112.8 KB) - added by diver 17 months ago.

Download all attachments as: .zip

Change History (7)

Changed 17 months ago by diver

Attachment: Repositories.png added

comment:1 Changed 17 months ago by diver

Description: modified (diff)

comment:2 Changed 17 months ago by diver

Description: modified (diff)

comment:3 Changed 17 months ago by diver

Turned out it was due to not "http://" not being there. Overwriting it once again with

pkgman add http://eu.hpkg.haiku-os.org/haikuports/master/repository/x86_gcc2/current

fixed it. Still a bug of course.

comment:4 Changed 17 months ago by diver

Description: modified (diff)
Summary: [Repositories] shows wrong repo as enabled[Repositories] ignores repos not starting with http://

comment:5 Changed 17 months ago by perelandra

Yes this is an invalid URL so gets rejected here: https://github.com/haiku/haiku/blob/master/src/preferences/repositories/RepositoriesView.cpp#L640

Seems like pkgman should enforce valid URLs, somewhere before or within this call: https://github.com/haiku/haiku/blob/master/src/bin/pkgman/command_add_repo.cpp#L90

comment:6 Changed 2 months ago by diver

Resolution: fixed
Status: newclosed

Fixed in hrev52848.

Note: See TracTickets for help on using tickets.