Opened 7 years ago
Closed 7 years ago
#13793 closed enhancement (fixed)
USB-ECM: support for QEMU USB network devices
Reported by: | korli | Owned by: | mmlr |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | Drivers/Network/usb_ecm | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
QEMU can configure USB network devices with for instance: -netdev user,id=mynet0 -device usb-net,netdev=mynet0
This patch adds support for it. It needs to be tested for possible regressions.
Attachments (1)
Change History (8)
by , 7 years ago
Attachment: | 0001-usb_ecm-support-for-QEmu-CDCE-network-device.patch added |
---|
comment:1 by , 7 years ago
patch: | 0 → 1 |
---|
comment:2 by , 7 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 7 years ago
I can eventually break each loop at the end. I thought the changes might break things for ECM devices (like phones), may I "as is" commit and request testing afterwards?
comment:5 by , 7 years ago
Component: | Drivers/Network → Drivers/Network/usb_ecm |
---|
comment:6 by , 7 years ago
I don't see why the change would break existing hardware, as presumably there simply wouldn't be multiple configurations?
To avoid the goto I'd set a bool found to true and break out of the outer loop when set (or add it to the loop condition). But you can also go ahead and push as is.
comment:7 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Thanks for the feedback, applied in hrev51606.
Michael, please kindly review!