Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#13812 closed bug (fixed)

[keystore_server] With big font authorization window is useless

Reported by: Janus Owned by: mmlr
Priority: normal Milestone: Unscheduled
Component: Servers/keystore_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Attachments (2)

keystore_server.png (58.2 KB) - added by Janus 17 months ago.
Reworked.png (28.1 KB) - added by Janus 17 months ago.

Download all attachments as: .zip

Change History (12)

Changed 17 months ago by Janus

Attachment: keystore_server.png added

comment:1 Changed 17 months ago by Janus

Has a Patch: set

comment:2 Changed 17 months ago by Janus

Description: modified (diff)

comment:3 Changed 17 months ago by pulkomandy

The wording in this window sounds very programmer-ish. What about "The application X wants to {add;remove;access} keys from keyring Y" ? It would waste a lot less space.

As for the problem, it is probably the same as in FirstBootPrompt and Locale: one needs to call ResizeToPreferred after setting the text in a BTextView, and a reasonable minimal width should be forced on it so that GetHeightForWidth gives meaningful results.

comment:4 Changed 17 months ago by diver

Whoever wants to work on that make sure to check out #11315 too :)

Changed 17 months ago by Janus

Attachment: Reworked.png added

comment:5 in reply to:  3 Changed 17 months ago by Janus

Replying to PulkoMandy:

The wording in this window sounds very programmer-ish. What about "The application X wants to {add;remove;access} keys from keyring Y" ? It would waste a lot less space.

I like your idea, but the wording is very problematic, the action string from the server are not internationalized. And with different languages can be difficult to compose a correct sentence.

The problem in the ticket is solved, I think some change in the TextView.

Replying to diver:

From #11315 "I think this window would look better with an icon. Also, maybe make an app path clickable?"

I don't find particularly useful make the app path clickable is the path of the app that has opened this window. I miss something?

I have cleaned up the code and added the server icon.

I think the problem of the wording need a different approach. Thoughts?

comment:6 Changed 17 months ago by pulkomandy

We have BMessageFormat which is designed to make such complex strings localizable. However, it currently only accepts one variable, so we would need to extend the API (the ICU backend handles multiple variables fine).

comment:7 in reply to:  6 Changed 17 months ago by Janus

Clean up in hrev51630.

comment:8 Changed 17 months ago by Janus

Resolution: fixed
Status: newclosed

This is solved with some commit in the BTextView area... There is a ticket for the i18n issue discussed in this thicket here #13815.

comment:9 Changed 17 months ago by diver

Does it use an app icon or keystore_server icon? IMO it should be the former.

comment:10 Changed 17 months ago by Janus

This ticket is for the big fonts problem. The ticket for the icon is still open. The window need improvements (#13815, #11315), but because I rewrote the layout I added an icon as a placeholder.

In my opinion it should use the icon of the app with a overlay of a lockpad, but the overlay lockpad icon in the folder artwork is too different from the haiku style that could be very confusing.

Note: See TracTickets for help on using tickets.