Opened 12 years ago

Closed 11 years ago

#1391 closed bug (fixed)

[Tracker] don't show icons for volumes in mount menu (easy)

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Mount menu doesn't show volume icon, only volume label.

Attachments (1)

Ticket 1391 - Volume Mount Icons.diff (882 bytes) - added by anxiety 11 years ago.
Mostly implimented already but commented out.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by diver

Summary: [Tracker] no volume icon in mount menu[Tracker] don't show icons for volumes in mount menu

comment:2 Changed 11 years ago by diver

Summary: [Tracker] don't show icons for volumes in mount menu[Tracker] don't show icons for volumes in mount menu (easy)

Changed 11 years ago by anxiety

Mostly implimented already but commented out.

comment:3 in reply to:  description Changed 11 years ago by anxiety

I've tested it a couple times, the patch I supplied doesn't seem to have any problems that I'm aware of.

comment:4 Changed 11 years ago by diver

Could someone take a look at this patch?

comment:5 Changed 11 years ago by axeld

The patch looks good - the problem of this code is just that we currently have no way for a device to get a new style icon, and no icon looks better than the wrong one, IMO.

I'll see what I can do about changing this, and then we can apply this patch, too.

comment:6 Changed 11 years ago by axeld

Resolution: fixed
Status: newclosed

Thanks for the patch, I've applied it (among other stuff) in hrev27001.

Note: See TracTickets for help on using tickets.