[File Copy Operations] Copied files from RO USB to RW USB are RO (Read-only)

[al_xv]

I copied 10 files from a Read-Only USB HDD to a Read-Write enabled USB flash drive. I didn't notice right away in Haiku, but upon inserting the Flash drive into a Linux machine, I noticed all files I copied had Read-Only permissions (locked file icon overlay). File permissions can be corrected manually.

Steps to Reproduce:

• Mount a USB drive as Read-Only.
• Mount a 2nd USB drive as Read-Write
• Copy files from RO drive to RW drive.
• Checked copied files permissions

Result

Copied files are all Read-Only

Expected Result

Copied files match original permissions regardless of media Write permissions.

This seems like a logical result since the files are copied from RO media... however, the source files themselves are not RO, so this behavior is undesireable.

[diver]

What filesystem it is?

[al_xv]

Replying to diver:

What filesystem it is?

The Read-Only was FAT32 and NTFS (I actually copied files from 2 drives) The Read-Write drive was FAT32

[diver]

#11911 looks suspiciously similar.

[khallebal]

It may not even be a haiku problem, but a linux one, i've had the same behabiour in linux where haiku wasn't even involved, my guess is it's linux or/and xfce bug (if you're using this combination? ).

Did you check the pemissions of these files in haiku?

I'd suggest you retry the operation and check the permissions in haiku before anything else.

[korli]

See #10796

[korli]

Forgot we need to check if the FAT file-system add-on changes permissions when mounting read-only.

[korli]

It seems it does change the permissions on the fly:

​https://git.haiku-os.org/haiku/tree/src/add-ons/kernel/file_systems/fat/file.c#n174

​https://git.haiku-os.org/haiku/tree/src/add-ons/kernel/file_systems/fat/file.c#n46

[korli]

and the NTFS addon does the same: ​https://git.haiku-os.org/haiku/tree/src/add-ons/kernel/file_systems/ntfs/fs_func.c#n852

[korli]

FAT behavior changed in hrev51846.

[korli]

NTFS behavior changed in hrev51847.

[al_xv]

Replying to khaled:

Did you check the pemissions of these files in haiku?

I'd suggest you retry the operation and check the permissions in haiku before anything else.

Retried copy operations and copied files are RO in Haiku as well.

Will retest with hrev51847.

[al_xv]

Verrified fixed on hrev51847 liveCD. Confirmed with FAT32 to FAT32 file copy. Copied file permissions matched original file on RO drive.

[korli]

Thanks for the feedback!