#14295 closed bug (fixed)

Add FBC padding to BControlLook

Reported by: pulkomandy Owned by: nobody
Priority: blocker Milestone: R1/beta1
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc: jscipione
Blocked By: Blocking:
Has a Patch: no Platform: All


It's part of libbe, and used by several apps/libs outside of Haiku (WebKit, Qt, anything using libshared, ACE, ...)

We should freeze it's ABI before shipping beta1.

Change History (8)

comment:1 by waddlesplash, 18 months ago

Well, since nothing outside the tree currently *creates* a BControlLook, only *uses* it, adding FBC padding should not require a mass rebuild. We do need to finish the presently-ongoing bikeshed to determine if there are any other changes to be made, though.

comment:2 by pulkomandy, 18 months ago

We don't need to solve the bikeshed, only complete and merge https://review.haiku-os.org/#/c/haiku/+/351/

comment:3 by waddlesplash, 18 months ago

Cc: jscipione added

CC jscipione: What's your status here? Easy enough to add the FBC padding, but the actual changes to the API depend on you.

I really don't see how they're needed for the beta, so, if they aren't ready, they just won't make it in.

comment:4 by jscipione, 18 months ago

Don't hold up beta on me but would be nice to get fbc padding methods before we freeze the API

comment:5 by waddlesplash, 18 months ago

Oh, I just realized -- BControlLook is in BPrivate. So it doesn't seem to make a lot of sense to add FBC padding while it's there, as we'll need to break ABI to remove it from there, and I don't think we should make such an ABI break so close to beta. Or maybe we should?

comment:6 by waddlesplash, 18 months ago

Added a Gerrit changeset for that: https://review.haiku-os.org/c/haiku/+/464

PulkoMandy, if you think it makes sense (I'm still on the fence), please merge immediately. I'll deal with the package builders later.

comment:7 by pulkomandy, 17 months ago

Mh, I don't know if we should move it out of BPrivate just yet. I think BControlLook is not mature and the API would need a complete review and cleanup before we do that. I would prefer that we keep it private for now so that it doesn't get in the way when we add new control looks and try to get them to look right.

FBC would then just be a way to limit ABI breakage when we make small changes, but not a commitment for complete ABI stability yet.

comment:8 by waddlesplash, 17 months ago

Resolution: fixed
Status: newclosed

Done in hrev52224.

Note: See TracTickets for help on using tickets.