#14445 closed bug (fixed)

New "revision" scheme too wide in AboutSystem

Reported by: pulkomandy Owned by: nobody
Priority: normal Milestone: R1/beta1
Component: Applications/AboutSystem Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

AboutSystem used to show only the hrev in the "Version:" field.

Now it shows a very long string with hrev, short commit hash, branch name, and a bunch of other things.

This is exactly what we tried to avoid with the hrevs. Having a short, sequential, unique identifier that the user can easily understand.

I would prefer that we revert to "just the hrev" here, or if people really want an ugly long cryptic string, at least we should find some way to linebreak it so that the left pane of AboutSystem does not become so wide, as the important part of the AboutSystem window is on the right.

Change History (3)

comment:1 Changed 11 months ago by cb88

HAIKU_REVISION is definitely a developer convenience feature... not a user feature. That said it's more of an annoyance to anyone checking out from github and then having your build fail and having to "lie" about the HAIKU_REVISION to the build system....

Users, probably won't care if just the Release Major / Minor + hash is displayed instead of rSOMEBIGSEQUENTIALNUMBER.

What about a short hash for convenience of reporting it would have to be long enough to not collide often, and short enough to not be onerous to type.

https://stackoverflow.com/questions/18134627/how-much-of-a-git-sha-is-generally-considered-necessary-to-uniquely-identify-a

This would automatically generate the shortest unique hash for a commit.

git rev-parse --short

Just about every open source project out there these days does somthing like this where they still have End user facing major minor numbers but.... the actual commit is a hash.

Last edited 11 months ago by cb88 (previous) (diff)

comment:2 Changed 10 months ago by waddlesplash

Now it shows a very long string with hrev, short commit hash, branch name, and a bunch of other things.

This is exactly what we tried to avoid with the hrevs. Having a short, sequential, unique identifier that the user can easily understand.

Well, the A4 hrevs included the branch name in the hrev, so at least we need that somewhere. I'll see about cutting down some of the other items; probably just branch + tag + commit count is enough.

comment:3 Changed 10 months ago by waddlesplash

Resolution: fixed
Status: newclosed

Fixed in hrev52347.

Note: See TracTickets for help on using tickets.