[HaikuDepot] wrong background color for email and webpage icons

[diver]

hrev52360.

[apl-haiku]

I have investigated the HVIF data and the icons are fine; no shaded background there and the icon looks really good.

The view class that renders the icons is BitmapView and it draws a background of the low colour. This class is used in different places in HD, but in this case with PackageInfoView the parent window is using the B_PANEL_BACKGROUND_COLOR (1) as the background color with a tint of kContentTint.

BitmapView "adopts" the colours of the parent view in BitmapView::AllAttached but here the parent seems not to have the tint. I suspect that the actual parent is an instance of BGroupView. It seems that in PackageInfoView::AllAttached an attempt is made to relay the top-level colours down into the children views such that perhaps the BitmapView might pick it up?

In any case, when the BitmapView::DrawBackground is invoked it has the right UI colour for low, but is missing the tint which is why it renders with a slightly different saturation compared to the surrounding window.

I am a bit confused where the low UI colour might be being set elsewhere. I did override BitmapView::SetLowUIColor but this didn't get hit.

I haven't been able to track this one down yet.

[X512]

Replying to apl-haiku:

BitmapView "adopts" the colours of the parent view in BitmapView::AllAttached but here the parent seems not to have the tint.

With recent changes Haiku supports transparent views, no adopting is needed. You need to set B_TRANSPARENT_BACKGROUND view flag and SetViewColor(B_TRANSPARENT_COLOR).

[waddlesplash]

Fixed in hrev54068.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone