Opened 12 days ago

Last modified 12 days ago

#14632 assigned bug

Fail to edit comment/rating

Reported by: humdinger Owned by: apl-haiku
Priority: normal Milestone: Unscheduled
Component: Applications/HaikuDepot Version: R1/beta1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev52295+100, 32bit

I'm only able to edit the comment/rating of a package if I log out and in again. Otherwise I get an alert "Authorization or security issue".

(BTW, what's the checkbox in front of the rating stars for in the rate/comment dialog? I expected deactivating the checkbox would remove the rating, but it doesn't...)

Attachments (2)

1-edit-rating.txt (7.1 KB) - added by humdinger 12 days ago.
failed editing
2-logout-in_rating.txt (7.3 KB) - added by humdinger 12 days ago.
success after logout/in

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 days ago by humdinger

Owner: changed from stippi to apl-haiku
Status: newassigned

comment:2 Changed 12 days ago by vidrep

I was able to log in, change the star rating, and edit my comments without any issue on installed apps. Currently running hrev52394 x86_64.

comment:3 Changed 12 days ago by apl-haiku

I'm only able to edit the comment/rating of a package if I log out and in again.

That seems strange. Do I understand this correctly;

  1. Login
  2. Make a comment
  3. Attempt to edit comment - fails
  4. Logout
  5. Login
  6. Attempt to edit comment - succeeds

Are you able to get the trace log and see if the HTTP request to save the comment has your authentication on it?

BTW, what's the checkbox in front of the rating stars for in the rate/comment dialog?

A rating consists of;

  • Stability
  • Numerical rating 0..5
  • Comments

You are able to make a rating that just has a comment or a rating that just has just a numerical value (stars) and no comment. In the case that you do not want to supply a numerical rating then you should set the checkbox to 'off' state and this will mean that for that rating, the numerical value stored is NULL and there will not influence on the average rating for that package from that rating.

comment:4 in reply to:  3 Changed 12 days ago by humdinger

Replying to apl-haiku:

That seems strange. Do I understand this correctly; [items 1-6]

Yes. Exactly right.
I attach 2 logs:

  1. when I try to edit the rating and I get the authorization error
  2. right after doing 1. I log out and in and edit a rating successfully

(I redacted my password and token)

BTW, what's the checkbox in front of the rating stars for in the rate/comment dialog?

[...]In the case that you do not want to supply a numerical rating then you should set the checkbox to 'off' state and this will mean that for that rating, the numerical value stored is NULL and there will not influence on the average rating for that package from that rating.

Looks like that's not working. I un-tisk the checkbox, but I see the rating still in the "Rating" tab of HaikuDepot and the number of votes and their average is still the same. Editing the rating again shows the checkbox is ticked.

Changed 12 days ago by humdinger

Attachment: 1-edit-rating.txt added

failed editing

Changed 12 days ago by humdinger

Attachment: 2-logout-in_rating.txt added

success after logout/in

Note: See TracTickets for help on using tickets.