Application Crashes when Missing SSH Port (easy)

[krb2018]

Launching RemoteDesktop myuser@myhost -s from Terminal causes an error that prevents the application from continuing. Crash does not occur unless port isn't supplied for -s, so it might be a problem with input validation. I verified that it doesn't matter whether the host and username are valid, as it happens regardless.

[krb2018]

Crash Report

[leavengood]

It does look like the logic is wrong here:

​https://git.haiku-os.org/haiku/tree/src/apps/remotedesktop/RemoteDesktop.cpp#n96

if (strcmp(argv[i], "-s") == 0) {
	if (argc >= i + 1
		&& sscanf(argv[i + 1], "%" B_SCNu16, &sshPort) == 1) {
		i++;
	}

It should be if (argc > i + 1, or it should mimic some of the other blocks which invert the logic and then show the usage if the logic fails.

If no one else makes this small fix I'll make it next time I am doing Haiku development.

[dgillman]

Addressing in: ​https://review.haiku-os.org/c/haiku/+/5596

Seems like none of the parameter validation worked as coded. Updated logic for all parameter validation.

[waddlesplash]

Fix was merged in hrev56420