Opened 4 days ago

Closed 6 hours ago

#14959 closed bug (fixed)

USB Ethernet adapter causing KDL

Reported by: mrentropy Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Drivers/USB/XHCI Version: R1/Development
Keywords: ethernet, insignia, gigabit Cc:
Blocked By: Blocking:
Has a Patch: no Platform: x86-64

Description

Device: Insignia USB 3.0 to Gigabit Ethernet Adapter Model No: NS-PU98635/NS-PU98635-C

Was working plugged into a USB2 port with hrev52947 x86_64

After updating to hrev52992, booting with the device plugged into USB2 or USB3 caused Haiku to enter KDL. Plugging device into a USB2 port when Haiku was fully booted also caused KDL.

Attachments (4)

listusb.txt (882 bytes) - added by mrentropy 4 days ago.
Contents of listusb when device was working
syslog (160.5 KB) - added by mrentropy 4 days ago.
Syslog from when device was working hrev52947
IMG_1451.HEIC (1.7 MB) - added by mrentropy 4 days ago.
KDL when booting with device attached with hrev52992
IMG_1451.jpg (1.5 MB) - added by waddlesplash 4 days ago.

Change History (8)

Changed 4 days ago by mrentropy

Attachment: listusb.txt added

Contents of listusb when device was working

Changed 4 days ago by mrentropy

Attachment: syslog added

Syslog from when device was working hrev52947

Changed 4 days ago by mrentropy

Attachment: IMG_1451.HEIC added

KDL when booting with device attached with hrev52992

Changed 4 days ago by waddlesplash

Attachment: IMG_1451.jpg added

comment:1 Changed 4 days ago by waddlesplash

Please attach a more commonly readable file format, next time...

At any rate, this has little to do with USB network drivers, it appears I just messed up lock order somehow.

comment:2 Changed 4 days ago by waddlesplash

So, I really don't understand how I messed this up, the code looks perfectly fine to me. We lock the lock once at the top of the function; there is no way for mutex_lock to fail in KDEBUG mode (that I can tell), and then there is only one way out at the bottom, and we unlock the mutex there. How does this lead to a double-unlock?

comment:3 Changed 35 hours ago by waddlesplash

Please retest after hrev52997.

comment:4 Changed 6 hours ago by waddlesplash

Resolution: fixed
Status: newclosed

Another user reported on the forums that the KDL with USB-ECM devices is now gone.

Note: See TracTickets for help on using tickets.