Opened 2 years ago

Last modified 11 months ago

#14985 new enhancement

Have concourse build changes submitted for review on Gerrit

Reported by: pulkomandy Owned by: haiku-web
Priority: normal Milestone: Unscheduled
Component: Sys-Admin Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description (last modified by pulkomandy)

It would be nice to have concourse check that changes submitted on Gerrit do not break the build. Later on we can also integrate running haiku-format or other checks, too.

Changes needed:

  • Concourse needs to be triggered somehow for each submitted change.
  • Gerrit has a REST API to submit the results. The bot can automatically +1 or -2 the build (in a category separate from human code reviews)
  • Gerrit is planning an API for inline review comments, so it could even pinpoint the exact place where there is a build error. But I think this is not in current releases yet.

Change History (2)

comment:1 by pulkomandy, 18 months ago

Description: modified (diff)
Summary: Have buildot build changes submitted for review on GerritHave concourse build changes submitted for review on Gerrit

comment:2 by pulkomandy, 11 months ago

FYI: Wireshark Gerrit does not trigger build automatically for all submitted changes, but only when devs set a specific flag (called "petri-dish" in their case). This can reduce the load on the buildbots.

Note: See TracTickets for help on using tickets.