Opened 5 years ago
Last modified 15 months ago
#14985 new enhancement
Have concourse build changes submitted for review on Gerrit — at Version 1
| Reported by: | pulkomandy | Owned by: | haiku-web |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Website/Gerrit | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description (last modified by )
It would be nice to have concourse check that changes submitted on Gerrit do not break the build. Later on we can also integrate running haiku-format or other checks, too.
Changes needed:
- Concourse needs to be triggered somehow for each submitted change.
- Gerrit has a REST API to submit the results. The bot can automatically +1 or -2 the build (in a category separate from human code reviews)
- Gerrit is planning an API for inline review comments, so it could even pinpoint the exact place where there is a build error. But I think this is not in current releases yet.
Change History (1)
comment:1 by , 4 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | Have buildot build changes submitted for review on Gerrit → Have concourse build changes submitted for review on Gerrit |
Note:
See TracTickets
for help on using tickets.
