Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#150 closed bug (fixed)

keyboard driver is opened twice

Reported by: marcusoverhagen Owned by: korli
Priority: normal Milestone: R1
Component: - General Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The keyboard driver input/keyboard/at/0 is opened twice by the input_server or some other app during startup.

After the first open(), it's immediately close()d. This is redundant, and wasting time, as keybaords may need 500ms or more to be reset, which is done during open.

syslog output:

KERN: devfs_publish_device input/keyboard/at/0, status = 0x00000000 [...] KERN: keyboard open() KERN: ps2_write_ctrl 0xab KERN: ps2_dev_command ff, 0 out, in 1, dev input/keyboard/ at/0 KERN: ps2_write_data 0xff KERN: ps2_interrupt: ctrl 0x15, data 0xfa (keyb) KERN: ps2_dev_command wait for ack res 00000000, wait-time 8727 KERN: ps2_dev_command got ACK KERN: ps2_dev_command waiting input data KERN: ps2_interrupt: ctrl 0x15, data 0xaa (keyb) KERN: ps2_dev_command wait for input res 00000000, in 1, wait-time 15964 KERN: ps2_dev_command data aa KERN: keyboard_open(): done. KERN: keyboard_close() KERN: keyboard open() KERN: ps2_write_ctrl 0xab KERN: ps2_dev_command ff, 0 out, in 1, dev input/keyboard/ at/0 KERN: ps2_write_data 0xff KERN: ps2_interrupt: ctrl 0x15, data 0xfa (keyb) KERN: ps2_dev_command wait for ack res 00000000, wait-time 6515 KERN: ps2_dev_command got ACK KERN: ps2_dev_command waiting input data KERN: ps2_interrupt: ctrl 0x15, data 0xaa (keyb) KERN: ps2_dev_command wait for input res 00000000, in 1, wait-time 16177 KERN: ps2_dev_command data aa KERN: keyboard_open(): done. KERN: keyboard ioctl() KERN: ps2: KB_SET_KEY_REPEAT_RATE -2115663531 KERN: ps2: set_typematic rate -2115663531, delay 500000 KERN: ps2_dev_command f3, 1 out, in 0, dev input/keyboard/ at/0 KERN: ps2_write_data 0xf3 KERN: ps2_interrupt: ctrl 0x15, data 0xfa (keyb) KERN: ps2_dev_command wait for ack res 00000000, wait-time 6436 KERN: ps2_dev_command got ACK KERN: ps2_write_data 0x3f KERN: ps2_interrupt: ctrl 0x15, data 0xfa (keyb) KERN: ps2_dev_command wait for ack res 00000000, wait-time 11236 KERN: ps2_dev_command got ACK KERN: keyboard ioctl() KERN: ps2: KB_SET_KEY_REPEAT_DELAY -326541474 KERN: ps2: set_typematic rate -2115663531, delay - 326541474 KERN: ps2_dev_command f3, 1 out, in 0, dev input/keyboard/ at/0 KERN: ps2_write_data 0xf3 KERN: ps2_interrupt: ctrl 0x15, data 0xfa (keyb) KERN: ps2_dev_command wait for ack res 00000000, wait-time 6875 KERN: ps2_dev_command got ACK KERN: ps2_write_data 0x1f KERN: ps2_interrupt: ctrl 0x15, data 0xfa (keyb) KERN: ps2_dev_command wait for ack res 00000000, wait-time 6583 KERN: ps2_dev_command got ACK KERN: keyboard ioctl() KERN: KB_SET_LEDS KERN: ps2_hid: set keyboard LEDs

Change History (4)

comment:1 by korli, 14 years ago

Resolution: fixed

comment:2 by korli, 14 years ago

Status: newclosed

comment:3 by korli, 14 years ago

the keyboard device addon was opening devices on scanning to be sure they were valid. we don't care and now open them when starting them. fixed in revision 16369.

comment:4 by marcusoverhagen, 14 years ago

verified, works

Note: See TracTickets for help on using tickets.