fifo_dequeue_buffer: Use of uninitialized lock

[T.Knez]

Hrev 53085 and 53086 have given me sporad kernel panics upon boot. It does not matter if it's a cold or warm boot, the issue can show itself regardless. This has never happend before on the machine. It has been rock solid running Haiku for at least the past year.

The computer in question is a Lenovo Thinkpad X61s running Haiku exclusively.

Output of listdev from the machine and a jpg picture of the kernel panic output is attached to this ticket.

[T.Knez]

Picture of the kernel panic output

[T.Knez]

Output of "listdev"

[waddlesplash]

The ​device_consumer_thread creation occurs after init_fifo is called. So I'm really not sure how this would occur. Memory corruption, maybe?

[waddlesplash]

hrev53085 is where I merged the new ipro1000 changes. So, maybe memory corruption indeed?

[waddlesplash]

kallisti5 reports the TUN driver triggers this on a VM with virtio, so the ipro1000 changes are unlikely to be related.

[kallisti5]

Yeah, my (*early*) work on top of mmu_man's tun work seems to trigger on hrev53077.

• On Haiku...
• Apply ​https://kallisti5.keybase.pub/Patches/0001-network-tun-Early-work-at-tunconfig-create.patch to haiku sources
• jam -q install-tun
• tunconfig create

<same KDL>

[kallisti5]

I should mention tun isn't in the images yet, and I haven't changed anything core network kit / server at this time.

[waddlesplash]

Should be fixed in hrev53089.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone