Opened 3 days ago

Closed 3 days ago

Last modified 3 days ago

#15165 closed bug (invalid)

[cgit] Unified diff not showing insertions

Reported by: idefix Owned by: haiku-web
Priority: normal Milestone:
Component: Website Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

See for example this commit: https://git.haiku-os.org/haiku/commit/?id=d230b5fdd3722564c2ddd7186d60749932324006

With diff mode set to unified, it only shows the deletions and none of the insertions.

With diff mode set to ssdiff, the insertions are now also shown.

Unified diff used to show insertions too in the past, if I remember correctly.

Attachments (2)

Screenshot_20190714-141405.jpg (557.5 KB) - added by idefix 3 days ago.
Screenshot showing commit in Opera browser on Android
Screenshot_20190714-194914.jpg (558.3 KB) - added by idefix 3 days ago.
Screenshot of Opera with ad-blocker off.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 days ago by waddlesplash

Not sure what you're talking about, I can see the insertions on both modes just fine. Can you provide a screenshot?

Changed 3 days ago by idefix

Screenshot showing commit in Opera browser on Android

comment:2 Changed 3 days ago by idefix

Ah, then it probably has to do something with the browser I'm using: Opera on Android

See attached screenshot.

comment:3 Changed 3 days ago by waddlesplash

That is extremely weird. Chrome on Android seems to display it fine here...

Changed 3 days ago by idefix

Screenshot of Opera with ad-blocker off.

comment:4 Changed 3 days ago by idefix

I found the culprit, it's the integrated ad-blocker that's suppressing the insertions. :D

Turning it off fixed it!

This ticket can be closed, I will open a ticket at Opera.

comment:5 Changed 3 days ago by waddlesplash

Resolution: invalid
Status: newclosed

comment:6 Changed 3 days ago by waddlesplash

OK thanks for the feedback!

Note: See TracTickets for help on using tickets.