"minimum" build target includes non-functional Debugger

[simonsouth]

Building a "minimum" target (with e.g. jam -q @minimum-raw) produces an image that includes Debugger, but the application can't be opened: It's missing from the Applications menu, and launching it from Terminal fails with

runtime_loader: Cannot open file libedit.so.0: No such file or directory

I'll post a small patch that fixes this---it's handy being able to quickly build a new OS image to debug changes to the system.

[simonsouth]

I've uploaded the patch for review here: ​https://review.haiku-os.org/c/haiku/+/1713

[waddlesplash]

As noted on IRC, for posterity:

8:54 PM <•waddlesplash> simonsouth: your fix does work but is technically incorrect; the right one is to add libedit as a dependency of the haiku package if the build feature is enabled
8:54 PM <•waddlesplash> simonsouth: i.e. alongside all these: https://xref.plausible.coop/source/xref/haiku/src/data/package_infos/x86_64/haiku#75

[simonsouth]

I've updated the patch following waddlesplash's comment above: Now libedit is added when needed as a dependency to the haiku package, for each of the platforms Haiku supports.

I've tested this new set of changes on x86_64 and it works. I'll also check to make sure the arm build still completes. Everything else looks right to me but please check carefully!

[simonsouth]

The arm build completes but the resulting haiku.hpkg neither includes Debugger nor specifies libedit as a dependency. (It does include the symbolic link in the Applications menu, though.)

I'm not sure why this is. Do we not build Debugger on arm yet? If I've made a mistake, I don't see it.

[waddlesplash]

I'm not sure why this is. Do we not build Debugger on arm yet? If I've made a mistake, I don't see it.

As specified in the minimum definition:

Debugger@libedit 

The "@" means only build if one of those BuildFeatures are activated. It appears libedit is not available in the ARM package repository (which was generated from the bootstrap package set), so Debugger isn't built.

[waddlesplash]

Merged with one small change -- I removed the Deskbar symlink for now. It appears those are not FFilterByBuildFeatures'd, and I didn't check to see what the side effects of doing that there would be, so let's just leave it out for now. Debugger should still be perfectly usable.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone