Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#15269 closed bug (fixed)

Wrong BMenuBar width

Reported by: X512 Owned by: leavengood
Priority: normal Milestone: R1/beta2
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

This is hrev53381. BMenuBar auto layout width is 1 bigger than it should be. I causes clipping beveled right side and corrupting design.

Attachments (4)

screenshot1 (1).png​ (7.4 KB ) - added by X512 5 years ago.
Before fix
screenshot2 (1).png​ (7.4 KB ) - added by X512 5 years ago.
After fix
0001-Fix-BMenuBar-width.patch​ (943 bytes ) - added by X512 5 years ago.
Patch
0001-fix-BMenuBar-width-in-Tracker.patch​ (826 bytes ) - added by X512 5 years ago.
patch for Tracker

Download all attachments as: .zip

Change History (9)

by X512, 5 years ago

Attachment: screenshot1 (1).png​ added

Before fix

by X512, 5 years ago

Attachment: screenshot2 (1).png​ added

After fix

by X512, 5 years ago

Attachment: 0001-Fix-BMenuBar-width.patch​ added

Patch

by X512, 5 years ago

Attachment: 0001-fix-BMenuBar-width-in-Tracker.patch​ added

patch for Tracker

comment:1 by waddlesplash, 5 years ago

Owner: changed from nobody to leavengood
Status: new → assigned

I'll assign this to Leavengood, he started picking up BMenu issues lately.

Please check that BFilePanels and the "Open with" window still look OK after the Tracker change.

Can you submit these changes to Gerrit?

comment:2 by leavengood, 5 years ago

Wow that is subtle, I don't know how you noticed it. It would help if you can get these to Gerrit otherwise I can apply them locally, do some testing, then push them up.

in reply to:  1 comment:3 by X512, 5 years ago

Replying to waddlesplash:

Please check that BFilePanels and the "Open with" window still look OK after the Tracker change.

BFilePanel look correct. BFilePanel use default layouting (​https://xref.plausible.coop/source/xref/haiku/src/kits/tracker/FilePanelPriv.cpp#679).

Can you submit these changes to Gerrit?

I do not have private GitHub account for now.

comment:4 by leavengood, 5 years ago

Resolution: → fixed
Status: assigned → closed

Thanks, I used git am to apply your patches, tested and pushed them up as hrev53397.

comment:5 by nielx, 4 years ago

Milestone: Unscheduled → R1/beta2

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

Note: See TracTickets for help on using tickets.