Exception: BLocker::IsLocked(BLocker)

[humdinger]

This is hrev53452, 32bit.

When applying a theme with ThemeManager, it crashes:

state: Exception (Segment violation)

Frame		IP			Function Name
-----------------------------------------------
0x71e72940	0x20b73e9	BLocker::IsLocked(BLocker) + 0x21 
	Disassembly:
		BLocker::IsLocked(BLocker):
		0x020b73c8:               55  push %ebp
		0x020b73c9:             89e5  mov %esp, %ebp
		0x020b73cb:           83ec10  sub $0x10, %esp
		0x020b73ce:               56  push %esi
		0x020b73cf:               53  push %ebx
		0x020b73d0:       e800000000  call 0x20b73d5
		0x020b73d5:               5b  pop %ebx
		0x020b73d6:     81c38f220c00  add $0xc228f, %ebx
		0x020b73dc:           8b7508  mov 0x8(%ebp), %esi
		0x020b73df:           83c4f4  add $0xfffffff4, %esp
		0x020b73e2:             6a00  push $0x0
		0x020b73e4:       e8efaee7ff  call 0x1f322d8
		0x020b73e9:           3b4608  cmp 0x8(%esi), %eax <--

	Frame memory:
		[0x71e72910]  ........H).q.s..   00 00 00 00 02 00 00 00 48 29 e7 71 d5 73 0b 02
		[0x71e72920]  d.......X).q....   64 96 17 02 00 00 00 00 58 29 e7 71 90 12 f0 00
		[0x71e72930]  .....).qh).q.t..   d8 82 f2 00 90 29 e7 71 68 29 e7 71 ab 74 0b 02
0x71e72970	0x20b74a6	BLocker::AcquireLock(int64, void*) + 0x1e 
0x71e729a0	0x20b72dd	BLocker::Lock() + 0x29 
0x71e729e0	0x1000bd9	BPrivate::media::PortPool::GetPort() + 0x25 
0x71e72a10	0x100188b	__Q38BPrivate5media12request_data + 0x23 
0x71e72aa0	0xfce2fb	BMediaFiles::RewindRefs(char*) + 0x2b 
0x71e72c20	0x23f27b9	SoundsThemesAddon::MakeTheme(BMessage&, long unsigned int) + 0xdd (/Source/HaikuThemeManager/src/addons/SoundsAddon.cpp:196)

See ​https://github.com/mmuman/HaikuThemeManager/blob/master/src/addons/SoundsAddon.cpp line 196

Jessica on IRC opines: [20:03] <jessicah> it's the change around port pool init

[leavengood]

I will change how the PortPool is initialized to fix this and other related issues.

[leavengood]

This should have been fixed by Adrien in hrev53528, can you check humdinger?

[humdinger]

I confirm, ThemeManager doesn't crash anymore when changing themes. Thanks!

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone