#15359 closed bug (fixed)
rpmalloc has excessive memory usage under git gc
| Reported by: | luroh | Owned by: | waddlesplash |
|---|---|---|---|
| Priority: | high | Milestone: | R1/beta2 |
| Component: | System/libroot.so | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description (last modified by )
hrev53490, gcc2h.
OOM running git gc --aggressive on the Haiku repo in VBox with 2 GB RAM. Works fine with libroot_debug.
Attachments (2)
Change History (20)
by , 5 years ago
| Attachment: | area_waste.txt added |
|---|
by , 5 years ago
| Attachment: | listarea.txt added |
|---|
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Summary: | rpmalloc → rpmalloc has excessive memory usage under git gc |
|---|
comment:3 by , 5 years ago
comment:4 by , 5 years ago
Even without running git gc, the mere fact or booting, doing git fetch on two different repos at once results in "fork: Not enough memory", and making the system unusable since one can't run anything.
I guess rpmalloc is used by the kernel as well…
comment:5 by , 5 years ago
Right after a reboot here in this vbox VM (1GB of RAM), jam clean gives vfork: Out of memory :-(
comment:6 by , 5 years ago
rpmalloc is definitely not used by the kernel, it still has its own allocator.
It appears hoard3 is now under the Apache license, unlike GPLv3 as it was before. So maybe we should reconsider it.
comment:7 by , 5 years ago
Oh, actually that was with LD_PRELOAD=libroot_debug.so which does use quite a lot. Removing it seems to actually compile stuff…
comment:8 by , 5 years ago
Not to sound alarming but Haiku is getting totally unusable due to this… maybe we should revert to the previous allocator until rpmalloc is fixed?
I had to bump my VM to 4GB of RAM to build just a single package, and I couldn't get it to build again even after rebooting 10 times and various attempts :)
comment:9 by , 5 years ago
That doesn't make any sense; I've built plenty of apps (including GCC!) on this VM with only 2GB of RAM. Are you sure that's the problem here? (And that you aren't somehow using the debug or guarded heaps?)
comment:10 by , 5 years ago
No, I tried with libroot_debug too but that didn't change much.
Hmm this VM only has 200MB of swap… disabling it still fails. I don't have much space left but I could try to enlarge it. I any case it used to work that way.
comment:13 by , 5 years ago
| Milestone: | Unscheduled → R1/beta2 |
|---|---|
| Priority: | normal → high |
comment:14 by , 5 years ago
I'm wondering if this could be specific to single vcpu (I only have one in vbox due to a bug in the guest-additions). I could try with more.
comment:15 by , 5 years ago
| Milestone: | R1/beta2 → Unscheduled |
|---|
We will not be using rpmalloc in beta2 if this is not fixed, so, removing it from beta2 milestone.
comment:16 by , 5 years ago
| Blocked By: | 15495 added |
|---|
comment:17 by , 5 years ago
| Blocked By: | 15495 removed |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
rpmalloc is now just gone, so this is "fixed".
comment:18 by , 5 years ago
| Milestone: | Unscheduled → R1/beta2 |
|---|
Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone
May be another instance of https://github.com/mjansson/rpmalloc/issues/111 -- added a comment there.