Opened 5 years ago

Closed 5 years ago

#15419 closed bug (not reproducible)

Resizing window crashes HaikuDepot

Reported by: humdinger Owned by: stippi
Priority: normal Milestone: Unscheduled
Component: Applications/HaikuDepot Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #15093
Platform: All

Description

This is hrev53538, 32bit.

  • go to the "Featured packages" tab
  • resize the window

Boom: 

thread 5640: w>HaikuDepot 
state: Exception (Segment violation)

Frame		IP			Function Name
-----------------------------------------------
0x71223c80	0x18e18ad	BTwoDimensionalLayout::LocalLayouter::AddHeightForWidthConstraints(BTwoDimensionalLayout::VerticalCompoundLayouter*, BPrivate::Layout::Layouter*, BLayoutContext*) + 0x125 
	Disassembly:
		BTwoDimensionalLayout::LocalLayouter::AddHeightForWidthConstraints(BTwoDimensionalLayout::VerticalCompoundLayouter*, BPrivate::Layout::Layouter*, BLayoutContext*):
[snip]
	Frame memory:
		[0x71223c14]  ..........pA...N   00 00 00 00 01 00 00 00 00 00 70 41 00 00 80 4e
		[0x71223c24]  ..pAx<"q.....F..   00 00 70 41 78 3c 22 71 96 17 8e 01 b8 46 a4 01
		[0x71223c34]  ........~.......   c0 a4 c2 09 00 00 00 00 7e 17 8e 01 dc a4 c2 09
		[0x71223c44]  ................   c0 a4 c2 09 dc a4 c2 09 c0 c3 a5 01 00 00 00 00
		[0x71223c54]  .... "V...pA...N   01 00 00 00 20 22 56 07 00 00 70 41 00 00 80 4e
		[0x71223c64]  ..pA............   00 00 70 41 05 00 00 00 00 00 00 00 01 00 00 00
		[0x71223c74]  .....<"q....       01 00 00 00 b8 3c 22 71 9d 08 8e 01
0x71223cc0	0x18e0898	BTwoDimensionalLayout::VerticalCompoundLayouter::InternalGetHeightForWidth(BTwoDimensionalLayout::LocalLayouter*, BLayoutContext*, bool, void*) + 0x104 
0x71223d10	0x18e09b1	BTwoDimensionalLayout::VerticalCompoundLayouter::DoLayout(float, BTwoDimensionalLayout::LocalLayouter*, BLayoutContext*) + 0x45 
0x71223d40	0x18e039b	BTwoDimensionalLayout::CompoundLayouter::Layout(float, BTwoDimensionalLayout::LocalLayouter*, BLayoutContext*) + 0x53 
0x71223d90	0x18e0f93	BTwoDimensionalLayout::LocalLayouter::Layout(BSize) + 0x47 
0x71223e10	0x18dfaed	BTwoDimensionalLayout::DoLayout() + 0x79 
0x71223e50	0x187982e	BLayout::_LayoutWithinContext(bool, BLayoutContext*) + 0x92 
0x71223e90	0x18ee898	BView::DoLayout() + 0x40 
0x71223ec0	0x18eeb86	BView::_Layout(bool, BLayoutContext*) + 0x7a 
0x71223ef0	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71223f20	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71223f50	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71223f80	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71223fb0	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71223fe0	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71224010	0x18eebdd	BView::_Layout(bool, BLayoutContext*) + 0xd1 
0x71224080	0x18ee779	BView::Layout(bool) + 0x31 
0x712240b0	0x18ee83f	BView::Relayout() + 0x63 
0x71224140	0x18ef9f0	BView::_ResizeBy(int32, int32) + 0x48 
0x71224190	0x18fa54a	BWindow::_AdoptResize() + 0xbe 
0x71224350	0x18f4dea	BWindow::DispatchMessage(BMessage*, BHandler*) + 0x4e6 
0x712243b0	0x18fa180	BWindow::task_looper() + 0x2d0 
0x712243e0	0x180cd0d	BLooper::_task0_(void*) + 0x3d 
0x71224408	0x1f6738b	thread_entry + 0x27 
00000000	0x639d8258	commpage_thread_exit + 0

Doesn't happen on "All packages" tab.
Full debug report attached.

Attachments (1)

HaikuDepot-5620-debug-19-10-2019-12-24-40.report​ (37.5 KB ) - added by humdinger 5 years ago.

Download all attachments as: .zip

Change History (7)

by humdinger, 5 years ago

Attachment: HaikuDepot-5620-debug-19-10-2019-12-24-40.report​ added

comment:1 by diver, 5 years ago

Blocking: 15093 added

comment:2 by apl-haiku, 5 years ago

(copied from the original ticket #15093...)

If the crash is arising from changes in the HaikuDepot source then the following timeline is applicable for further investigation;

  • hrev53170 (2019-05-29) - problem reported
  • hrev53167 (2019-05-26) - fix from Andrew "HaikuDepot: Fix Bug with Collation"
  • hrev53164 (2019-05-23) - fix from Andrew "HaikuDepot: Categories from Server"
  • hrev53159 (2019-05-24) - problem seen, but not reproducable
  • hrev53157 (2019-05-22) - fix from Andrew "HaikuDepot: Filtering Crash Resolution"
  • hrev53155 (2019-05-22) - fix from Andrew "HaikuDepot: Load Languages from HDS - Fixes"
  • hrev53131 (2019-04-19) - fix from Andrew "HaikuDepot: Load Languages from HDS"
  • hrev53063 (2019-04-13) - fix from waddlesplash "kernel/OS.h: Include sys/types.h instead of pthread.h."
  • --- (2019-03-?) - fixes from Andrew related to generation of model files

comment:3 by apl-haiku, 5 years ago

Hi Humdinger / diver; I was able to reproduce this bug reliably and spent quite a long time trying to narrow the time-frame of it's emergence down, but unfortunately I really can't seem to reproduce it any more which is frustrating. Is it still happening on your systems?

comment:4 by stippi, 5 years ago

To me it looked like it may be a bug in the height-for-width layout code, not HaikuDepot itself. I wasn't looking long enough at the time, but the height-for-width code creates some book-keeping structures and the error may be that it doesn't always initialize everything correctly. Is there perhaps a chance that the bug is no longer reproducible because we switched back to the previous allocator? It may affect how uninitialized memory in this code-path is pre-filled.

comment:5 by humdinger, 5 years ago

Yep, doesn't crash anymore with a later hrev. Resizing is kinda choppy though, much more than on the "All packages" tab.

comment:6 by apl-haiku, 5 years ago

Resolution: → not reproducible
Status: new → closed

The issue appears to no longer be happening.

Note: See TracTickets for help on using tickets.