Opened 12 years ago

Closed 11 years ago

#1543 closed bug (fixed)

Check libroot for Correct Use of errno (easy)

Reported by: bonefish Owned by: kaoutsis
Priority: normal Milestone: R1
Component: System/libroot.so Version: R1/pre-alpha1
Keywords: Cc: karma
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

While BeOS API functions usually return error codes directly, POSIX functions just indicate an error by a special return value (often -1 or a NULL pointer) and set errno to the actual error code. Our libroot code (src/system/libroot, particularly the posix subdirectory) needs to be reviewed in this respect.

Change History (10)

comment:1 by karma, 12 years ago

Cc: karma added

comment:2 by kaoutsis, 12 years ago

Owner: changed from axeld to kaoutsis
Status: newassigned

I will give it a try!

comment:3 by axeld, 12 years ago

Milestone: R1/alphaR1

comment:4 by korli, 12 years ago

Could you provide a status on this one please ?

in reply to:  4 ; comment:5 by kaoutsis, 12 years ago

Replying to korli:

Could you provide a status on this one please ?

Certainly;

  • several additions to posix functions have been made regarding setting errno

to the past 3 months (not only by me); (i don't remember exactly the particular functions names)

  • i have scan the posix subdirectory) for errno twice; but if it isn't urgent,

i would like to check again. I think we should leave this ticket open a little longer.

in reply to:  5 comment:6 by kaoutsis, 12 years ago

comment:7 by korli, 12 years ago

Ok. Full coverage is thus in progress. Thanks.

comment:8 by scottmc, 11 years ago

anything to update on this one?

in reply to:  8 comment:9 by kaoutsis, 11 years ago

Replying to scottmc:

anything to update on this one?

as far as my knowledge goes, i couldn't find any other cases. In my opinion we should close this ticket, and if someone finds a missing case, could open a ticket with that particular case.

comment:10 by axeld, 11 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.