[Gerrit] adds extra h to hrev in commit messages

[diver]

Mentioning revision number like hrev50495 creates hhrev50495 text in Gerrit. And the "h" from http is missing from the URL link.

See ​https://review.haiku-os.org/c/haiku/+/1956/4

Probably started after recent Gerrit update.

[pulkomandy]

Loosk like a regression in the Gerrit UI.

Here is our configuration:

[commentlink "trac"]
    match = "\\s#([0-9]+)"
    link = https://dev.haiku-os.org/ticket/$1
[commentlink "cgit"]
    match = hrev([0-9]+)
    link = https://git.haiku-os.org/haiku/tag/?h=hrev$1
[commentlink "cgit-buildtools"]
    match = btrev([0-9]+)
    link = https://git.haiku-os.org/buildtools/tag/?h=btrev$1

As far as I can see, the "h" is indeed matched by the regexp so I don't see how it can be duplicated because of a problem here.

[pulkomandy]

I have asked for help on Gerrit mailing lists: ​https://groups.google.com/forum/#!topic/repo-discuss/Vxm6Zkd4sGA

[pulkomandy]

And I found that it is in fact fixed in 2.16.16: ​https://bugs.chromium.org/p/gerrit/issues/detail?id=12197

So we should just update to that.

[pulkomandy]

We are now running 2.16.17.