Opened 5 years ago

Last modified 5 years ago

#15482 closed bug

[Gerrit] adds extra h to hrev in commit messages — at Version 3

Reported by: diver Owned by: kallisti5
Priority: normal Milestone: Unscheduled
Component: Website/Gerrit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #15748
Platform: All

Description (last modified by pulkomandy)

Mentioning revision number like hrev50495 creates hhrev50495 text in Gerrit. And the "h" from http is missing from the URL link.

See ​https://review.haiku-os.org/c/haiku/+/1956/4

Probably started after recent Gerrit update.

Change History (3)

comment:1 by pulkomandy, 5 years ago

Loosk like a regression in the Gerrit UI.

Here is our configuration: 

[commentlink "trac"]
    match = "\\s#([0-9]+)"
    link = https://dev.haiku-os.org/ticket/$1
[commentlink "cgit"]
    match = hrev([0-9]+)
    link = https://git.haiku-os.org/haiku/tag/?h=hrev$1
[commentlink "cgit-buildtools"]
    match = btrev([0-9]+)
    link = https://git.haiku-os.org/buildtools/tag/?h=btrev$1

As far as I can see, the "h" is indeed matched by the regexp so I don't see how it can be duplicated because of a problem here.

comment:2 by diver, 5 years ago

Blocking: 15748 added

comment:3 by pulkomandy, 5 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.