MediaPlayer: remove start media_server prompt

[nephele]

When starting MediaPlayer when media_server is down it will ask whether to start the server.

I would like this to be removed since either:
A: media_server has crashed and will soon be restarted
B: media_server is disabled on purpose in launch_roster

In either of these cases it does not seem apropriate for MediaPlayer to start media_server (especially since it would be duplicating launch_daemon functionality)

[korli]

This doesn't make much sense. What should MediaPlayer do then? Just quit?

[nephele]

No, It should attempt to establsish a connection again, with a backing off timeout, and then quit.

On what grounds does this not make sense? it is not the place of MediaPlayer to enforce whether a daemon is running or not, it is the one of launch_roster, MediaPlayer should never attempt to track or launch servers on it's own.

(On a similar note media_addon_server should be brought under supervision of launch_roster too)

[korli]

Hardly believable, when starting MediaPlayer, the user expects to be able to play a media file. Whatever is required has to be offered, in this case to ask the launch_daemon to start media services. Where is the duplicated functionality?

The application Mail does the same. It checks whether the mail daemon is running and offers to start it. This means it is also a consistent behavior.

[nephele]

Whatever is required has to be offered, in this case to ask the launch_daemon to start media services.

This ticket is just about removing the prompt,
either media_server is disabled on purpose and won't be brought up, or it crashed and will be brought back up, in either case MediaPlayer asking launch_daemon to launch them would likely be a noop I think.

In any case, asking the user about this is moot, the user shouldn't need to know what media_server is, does, or why and where it is required.