#15681 closed bug (fixed)
Gerrit oauth plugin will need an update to continue to work with github
| Reported by: | pulkomandy | Owned by: | nielx |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Sys-Admin | Version: | R1/Development |
| Keywords: | Cc: | anevilyak | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
We're starting to get emails from github on logon. The gerrit-oauth-provider devs are on it: https://github.com/davido/gerrit-oauth-provider/issues/135
We should watch for a fix there and update to a new release of the pluging when they're ready.
Change History (7)
comment:1 by , 5 years ago
| Cc: | added |
|---|
comment:2 by , 5 years ago
comment:3 by , 5 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
nielx, want to take a look? PulkoMandy's PR looks correct to me, so this just needs to be built and deployed.
comment:4 by , 5 years ago
| Status: | assigned → in-progress |
|---|
The changes have been merged. I will try to build and deploy a new image today.
comment:5 by , 5 years ago
| Milestone: | Unscheduled |
|---|---|
| Resolution: | → fixed |
| Status: | in-progress → closed |
New image deployed, so I hope this fixes the messages. I was still getting weekly messages from Github BTW. Let's see if this fixes it.
Other (maybe unrelated) question: any reason for not updating to a newer version of gerrit (they are at version 3.1 now), other than 'we never got around to it'?
comment:6 by , 5 years ago
The upgrades to new major releases usually need some work for migrating, and the code review workflow also sometimes changes a bit. So, it needs careful reading of the changelog to make sure we have the process right, and checking that all our needed plugins are available for the new version.
We should also check that the new version works in WebPositive before migrating. I tested https://gerrit-review.googlesource.com/q/status:open+project:gerrit and it currently doesn't seem to show any changes. Let's hope leorize's work on the network APIs can fix that!
comment:7 by , 5 years ago
Ok! For now the 2.16 version of Gerrit is still supported, so no rush to migrate just yet.
We don't get the mails anymore, apparently. We are still apparently using an older version of the plugin. The upstream ticket is solved and was backported to the Gerrit 2.16 version of the plugin as well.
So we just need to update: https://github.com/haiku/infrastructure/pull/55