Opened 14 months ago

Closed 11 months ago

Last modified 11 months ago

#15734 closed bug (fixed)

ICCP Known Incorrect RGB Profile

Reported by: dsuden Owned by: nobody
Priority: high Milestone: R1/beta2
Component: Add-Ons/Translators/PNG Version: R1/Development
Keywords: Cc: ttcoder
Blocked By: Blocking:
Platform: All

Description

I just updated to the latest Haiku build, and have begun getting the following error when launching a couple of the TT Systems apps. I can click past the errors and the apps still work, but it'd be great if the error didn't appear.

Attachments (1)

screenshot4.png (210.8 KB ) - added by dsuden 14 months ago.

Download all attachments as: .zip

Change History (12)

by dsuden, 14 months ago

Attachment: screenshot4.png added

comment:1 by ttcoder, 14 months ago

Cc: ttcoder added
Component: - GeneralAdd-Ons/Translators/PNG
Priority: normalhigh

Seems this is the culprit: https://git.haiku-os.org/haiku/commit/?id=450208975b6a059e645e8c2b4a77c346b9b03b71

For years we've seen this sent to stdout (or stderr?), but now we get 4 alerts in a row that must be dismissed before using the app (because the app has 4 pictures loaded from its .rsrc)

(edit: re-reading this ticket, I'm not sure whether the project has entered the "Joker (2019)" phase, or "Project Mayhem" phase, or the "Joseph Tainter/F-35/Zumwalt/LCS/Ford-supercarrier" phase; now if you'll excuse me, I have to brace my code to make it ready for future improvements such as class BFile popping up a BAlert on ctor errors and on Write() errors)

Last edited 14 months ago by ttcoder (previous) (diff)

comment:2 by waddlesplash, 14 months ago

but now we get 4 alerts in a row that must be dismissed before using the app (because the app has 4 pictures loaded from its .rsrc)

The warning seems to be saying that the PNGs have invalid color profiles embedded in them, so it is correctly informing the users that there is potential implicit data loss. We don't want to remove this warning; so, can you just fix the PNGs in your app?

comment:3 by pulkomandy, 14 months ago

Well, it's not nice that the error is necessarily an alert, it would be better if we notified the app and allowed it to decide if showing an alert is relevant. This may even break completely if you use the translation kit in a purely console app, I think (as there would be no app server link to open the alert)?

comment:4 by dsuden, 14 months ago

OK, we'll work it out on our end.

comment:5 by waddlesplash, 14 months ago

Resolution: no change required
Status: newclosed

It should be as simple as opening and re-saving the images in GIMP, which usually informs you of this problem and offers to automatically correct it. Let us know if you can't resolve it so easily.

comment:6 by nielx, 12 months ago

Milestone: Unscheduled

Remove milestone for tickets with status = closed and resolution != fixed

comment:7 by diver, 11 months ago

Resolution: no change required
Status: closedreopened

I think we need to reconsider this. Re-saving the images is not an option if they are on a read-only volume. Also ShowImage preloads existing images while opening images so you get this message even without directly opening such PNGs. Getting this errors in BAlerts is just way to annoying.

comment:9 by waddlesplash, 11 months ago

Resolution: fixed
Status: reopenedclosed

Fix merged in hrev54161.

comment:10 by nielx, 11 months ago

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

comment:11 by nielx, 11 months ago

Milestone: R1/beta2
Note: See TracTickets for help on using tickets.