Some headers should be rewritten

[korli]

Some headers were copied from BeOS, ignoring the license which doesn't allow that. We should rewrite them instead.

Here is a list:

headers/os/drivers/ISA.h
headers/os/drivers/PCI.h

[axeld]

I just rewrote TrackerAddOn.h and kernel/image.h. net_settings.h can probably be removed, as we don't support that API anymore. When we want to distribute headers as well (ie. a developer environment for Haiku) we should have replaced all Be headers with our own.

[jackburton]

I rewrote DirectWindow.h. Should we keep track of the headers which are already rewritten in some way ?

[korli]

Yeah, just add a "Done" section in the description and move the header from the current list to this section. It should be good enough :) Thanks for looking into this.

[jackburton]

By the way, do we really need all the headers reported in headers/build ? At least, I guess we don't need the whole interface kit.

[bonefish]

Replying to jackburton:

By the way, do we really need all the headers reported in headers/build ? At least, I guess we don't need the whole interface kit.

Nope, feel free to remove whatever is not needed.

[jackburton]

Is BMultiChannelControl used anywhere ? To me it looks like an older version of BChannelControl/BChannelSlider interface. We might decide to just drop it and stick with the latter.

[jackburton]

Input.h done.

[jackburton]

TextView.h was rewritten in hrev22688 by Vasilis Kaoutsis.

[julun]

PrintJob.h done in hrev24684

[korli]

These headers have been rewritten: headers/os/add-ons/input_server/InputServerDevice.h headers/os/interface/ChannelControl.h headers/os/media/BufferGroup.h headers/os/media/MediaFormats.h headers/os/media/Sound.h

[jackburton]

More headers done: headers/os/interface/MultiChannelControl.h, headers/os/interface/ChannelSlider.h, headers/os/app/PropertyInfo.h, headers/os/media/Buffer.h, headers/os/media/BufferConsumer.h, headers/os/media/TimeSource.h

[axeld]

Translation Kit headers done.

[stippi]

Going after more of the MediaKit headers from top to bottom...

[stippi]

Last of the MediaKit headers rewritten. I am going to let it rest for a while. Help greatly appreciated, it's not rocket since.

[jackburton]

I'm taking care of the device headers.

[jackburton]

Do we really need to keep NetPositive.h ? I don't think we implement this functionality anywhere.

[axeld]

I guess mmu_man wouldn't like if he couldn't build BeHappy anymore. But I wouldn't mind to remove it, and have this (rewritten) header as part of NetSurf instead (since it seems to adhere to this interface, AFAIK).

Embedding HTML in applications won't work via replicants in the future, but a BHTMLView, anyway.

[axeld]

Did bus_manager.h, and USB_printer.h.

[axeld]

Rewrote USB_rle.h, USB_spec.h, and midi_driver.h in hrev32901. I won't have the time to rewrite any other headers before the alpha release.

[jarz]

I've attached a patch for this ticket. I'm still in the process of getting Haiku built so I haven't been able to test it yet. I doubt my changes were substantial enough to cause problems.

[stippi]

Hi jarz, thanks for the patch. I've skimmed over it and spotted you changed some "ulong" defines to "uint64". But ulong is equivalent to uint32, so these changes definitely break things.

[jarz]

Tested patch

[jarz]

Thanks for the feedback stippi. I've been working on a project where ulong == uint64; I suppose I was on autopilot when I made those changes. I also used checkstyle this time and corrected the style errors it noted.

This patch successfully built against hrev35971.

[Disreali]

ping

[stippi]

Applied in hrev42958, sorry for the long delay! I've put the "#idfef cplusplus"s back in. The PCI.h patch needed to be applied back on top, which I've done by creating a patch from the current version of PCI.h to the revision that the patch was based on (ahm, the other way around) and applying the resulting patch on top of the file after applying the patch from this ticket to the old version. Hopyfully no screw ups.

[stippi]

... and reverted again for PCI.h and ISA.h which can't have been tested. The change of the types causes compiler errors in other Haiku modules, because signaturs of functions don't match anymore.

[nielx]

Obsoleted patch. See comment:41

[pulkomandy]

I was comparing our Game Kit headers with BeOS last week and I found that some have MIT License and Haiku copyright, yet they are identical to the BeOS one down to the comments and TODOs. So it looks like there was some "cheating" in this rewriting effort. We may want to review them all one last time before we close this ticket...

[korli]

Replying to pulkomandy:

I was comparing our Game Kit headers with BeOS last week and I found that some have MIT License and Haiku copyright, yet they are identical to the BeOS one down to the comments and TODOs. So it looks like there was some "cheating" in this rewriting effort. We may want to review them all one last time before we close this ticket...

Is it only headers/os/game/WindowScreen.h? Couldn't find any other.

[pulkomandy]

You can trace it easily from the commit logs:

Headers introduced in ​http://cgit.haiku-os.org/haiku/commit/headers/os/game?id=52a380120846174213ccce9c4aab0dda17c72083 (initial svn import) and ​http://cgit.haiku-os.org/haiku/commit/headers/os/game?id=4c2bc7e83c660cbc266d50f3d924115268912656 are copied from BeOS.

In ​http://cgit.haiku-os.org/haiku/commit/headers/os/game?id=4703fb5d8562169f672b3efe5203f1eb4d9ceb4a, you can see the licence changing for some of them, without any changes to the file contents.

Most of them were then edited over the years, I don't know at which point we can consider them a "rewrite".

[korli]

Replying to pulkomandy:

Most of them were then edited over the years, I don't know at which point we can consider them a "rewrite".

Well here is the list then: headers/os/game/DirectWindow.h headers/os/game/FileGameSound.h headers/os/game/GameSound.h headers/os/game/GameSoundDefs.h headers/os/game/PushGameSound.h headers/os/game/SimpleGameSound.h headers/os/game/StreamingGameSound.h headers/os/game/WindowScreen.h

headers/os/game/*Sound* were indeed derived from BeOS R5 headers.

[pulkomandy]

Updated with the work done during GCI 2019 (hrev53701, hrev53754, hrev53766, hrev53767).

[bipolar]

headers/os/drivers/ISA.h got rewritten on hrev56920.