[Deskbar] mini-mode confused state

[diver]

This is hrev53955.

I resized Deskbar to its maximum and switched to mini-mode.

[jscipione]

You have successfully triggered this known bug. The fix was taken out just before it was submitted because it was complained about. Moving Deskbar around fixes it?

[jscipione]

Fix was ​https://review.haiku-os.org/c/haiku/+/2253/21/src/apps/deskbar/BarView.cpp#583 but was removed... it should be put back in. See discussion in patch set.

[X512]

Replying to jscipione:

Fix was ​https://review.haiku-os.org/c/haiku/+/2253/21/src/apps/deskbar/BarView.cpp#583 but was removed... it should be put back in. See discussion in patch set.

fInlineScrollView->MoveTo(100000, -100000); is definitely wrong, some other solution should be used. Also note overlapping deskbar replicant with Tracker button.

[jscipione]

I want a solution but Hide() is definitely getting called so I don't know what else to do here.

[jscipione]

The overlap is caused by the inline scroll view drawing on top of Deskbar and the replicant re-drawing on top of it. The Tracker icon is a dead giveaway that this is the case. You can also see the resize control on the left side which should also be hidden but is drawing anyway.

[X512]

I resized Deskbar to its maximum and switched to mini-mode.

Can't reproduce bug by this steps.

[jscipione]

I can't either but I could earlier in development. I was hoping that my mode switching updates had fixed this bug but I have to imagine that diver was able to reproduce the bug somehow. Diver can you give us better steps on how you were able to trigger this bug? I know that you aren't in largest icon setting because I can see the Tracker icon and it's not 96x96.

[pulkomandy]

Have you checked that Hide() and Show() calls are balanced? There is a counter so if Show() was called twice, you need to call Hide() twice for it to have any effect. Could that be the case here?