[HaikuDepot] Featured packages selection became extremely slow (regression)

[diver]

hrev54069 x86_64.

Selecting packages in Featured packages view is extremely slow. This is a recent regression.

[nielx]

@apl-haiku could you review? AGMS has also found that this is slow, and he noticed that the window thread and the app-server thread have a maxed out cpu during the initial sync

[AGMS]

Not just the initial sync, when things are paused periodically. But after sync, it's busy doing something and the UI is very slow. Painfully slow. Switching to the All Packages tab brings back the speed. Maybe it's having trouble drawing big icons for Featured Packages? Or drawing something there that takes a while.

[apl-haiku]

It looks like it is excessive re-layouts happening. Similar to #14675. I am moving house right now so time is limited, but I will see if I can take a look at the suggestions on ​this PR and possibly it may help here. It looks like the re-layout is happening because of;

...
BAbstractLayout::MinSize()
...
BView::MinSize()
BWindow::UpdateSizeLimits()
BWindow::Layout(..)

[waddlesplash]

See what you think following hrev54192; at least for me selecting packages is now instantaneous.

[diver]

Thanks, it's instantaneous here too.