[Installer] WebPositive bookmarks are broken (regression)

[diver]

hrev54088 x86_64

Default WebPositive bookmarks can't be opened and lack icons. Same thing happened to Tracker templates.

Could be a problem with the CI?

[waddlesplash]

Possibly, but the CI was recently fixed for attribute issues. Is it still a problem in the most recent nightlies?

[diver]

Freshly installed hrev54105 from anyboot iso has the same problem.

[pulkomandy]

It's unclear from the ticket description, are the Tracker templates broken again or are you referring to a previous issue that has been fixed?

[diver]

Tracker templates are not visible in Tracker's "New" menu. However, if you open Tracker templates folder, select all and drag them a bit they appear in the New menu.

[TheClue]

Replying to diver:

Tracker templates are not visible in Tracker's "New" menu. However, if you open Tracker templates folder, select all and drag them a bit they appear in the New menu.

I was ready to submit this when I noticed it was reported already. I can confirm the strange behaviour: you just need to drag a bit the templates in their folder to make them show in the 'New' menu. The ones you select and drag are those you'll see.

They WILL stay there then even after a system reboot or tracker restart.

[pulkomandy]

Can you check the file attributes before and after nudging the files? I suspect Tracker automatically "identifies" them when doing this. Does it happen with the bookmarks too, or are these more broken than that?

[diver]

That didn't work with bookmarks.

[TheClue]

No attribute presents in template dile after nudging, can't check before (since it seems not reversible I should check in a clean install and unfortunately I can't do that so easily now)

[pulkomandy]

I don't reproduce when building haiku from haiku. So it is probably a problem with building from Linux only.

[bitigchi]

Reproducible with the latest master. Gives an error to select the application to open the bookmark, but still doesn't work even if Web+ is selected.

[pulkomandy]

Bookmark files are empty, all the data is in the attributes. So it makes sense that if the attributes go missing, the file won't work.

[nielx]

Beta2 status meeting: reassign to pulkomandy

[pulkomandy]

I don't reproduce this problem on my machine with XFS filesystem and USE_XATTR set. So it must be a problem specific to the buildbot configuration. Reassigning to kallisti5 since I don't have access to the buildbots.

[waddlesplash]

kallisti5 replied to me that he does not have the bandwidth to look into things this week, but he notes that the builders are running Docker images as specified in the "infrastructure" repo, so anyone can launch these and test builds with the exact configuration the CI uses.

Anyone have the time to look into that (maybe nielx?) If nobody else does, I might, we'll see...

[nielx]

Looking into it today. I will explore some theories and keep you guys up to date here.

[nielx]

I retried with the latest hrev54139 image, and it seems to work again. Could you verify @diver?

[bitigchi]

Tried with hrev54139, still reproducible.

[diver]

Did you try with a fresh install? Updating from a broken revision won't fix it as the files are outside of packages.

[nielx]

I tried the Live CD Image, if that helps. I verified that:

• There are bookmarks in WebPositive
• There are templates in the New menu in Tracker (right click on the desktop)

Did I look at the right things?

[nielx]

Interestingly enough, I get the same result on the x86_64 hrev54088 livecd when booting to desktop.

So was it an installer problem instead of a build problem? What were the exact circumstances under which this issue was discovered?

[bitigchi]

Ah, no, I've used my existing install. If that's the case, then it's probably fixed.

[nielx]

I did another test, and installed the hrev54139 to a fresh partition. Now I can reproduce the behaviour in this ticket. It seems to be an installer issue.

[pulkomandy]

Leorize, maybe you can have a look at this? You were the last to touch Installer CopyEngine code. Does it still copy attributes properly?

[nielx]

Proposed fix in ​https://review.haiku-os.org/c/haiku/+/2600

[nielx]

Submitted as hrev54144