`abort` function not marked as `noreturn`

[ahwayakchih]

I'm trying to build a C++ project, which has declarations like:

[[noreturn]] inline void Abort() {
    /* some code here, and then... */
    abort();
}

It errors when compiling, because abort() declared in Haiku is not marked as noreturn. I added call to exit(-1) at the end of function, but that's a bit ugly workaround.

Since abort() never returns anyway (or does it?), it should be ok to mark it as such, right? So, in stdlib.h, instead of:

extern void abort(void);

there could be:

extern void abort(void) __attribute__((noreturn));

[pulkomandy]

​https://review.haiku-os.org/c/haiku/+/2558

[waddlesplash]

Fix merged in hrev54125.

[ahwayakchih]

Thanks @pulkomandy and @waddlesplash :).

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone