Opened 7 months ago

Closed 6 months ago

#15982 closed enhancement (fixed)

[CharacterMap] Blocks that don't contain any characters could be greyed out (easy)

Reported by: pulkomandy Owned by: axeld
Priority: normal Milestone: R1/beta3
Component: Applications/CharacterMap Version: R1/Development
Keywords: Cc:
Blocked By: #3651 Blocking:
Platform: All

Description

In CharacterMap, the list of unicode blocks on the left should show greyed/disabled items for all blocks for which the current font does not provide any character.

Change History (4)

comment:1 by pulkomandy, 7 months ago

Blocked By: 3651 added
Blocking: 3651 removed

comment:2 by dsizzle, 7 months ago

I keep meaning to get back to this to finish it out. It requires a bit of a refactor of the app to do it "correctly" as the block list has no knowledge of the font (and hence the blocks contained). The blocks that are defined by BeOS are far fewer than the Character map contains, and looking up the non-Be blocks is less efficient. Also the blocks aren't cached so looking them up multiple times can be slow. I really should just finish this since I have all the context...

comment:3 by dsizzle, 7 months ago

pushed a CR for this ticket: https://review.haiku-os.org/c/haiku/+/2739

I decided not to do a larger refactor as the code changes are not bad. Performance is reasonable for large fonts with a lot of CJK characters.

comment:4 by pulkomandy, 6 months ago

Milestone: UnscheduledR1/beta3
Resolution: fixed
Status: newclosed

Merged in hrev54254. Thanks!

Note: See TracTickets for help on using tickets.