[HaikuDepot] is slow at populating All package list

[diver]

hrev54185 x86_64.

It takes HaikuDepot ~15 seconds to list All packages which is unacceptably slow.

Item count goes to 348 (for some reason it's always this number) after that it raises to 2540 then it resets to 0 and quickly increases to 2664. HaikuDepot was so much faster in beta1 *sigh*

[apl-haiku]

The sudden jump to zero packages is because of the code in MainWindow::_BulkLoadCompleteReceived then subsequently MainWindow::_AdoptModel;

fFeaturedPackagesView->Clear();
fPackageListView->Clear();

So it clears those two views and then reloads them with data. It is a bit tricky to prevent this quickly and easily because the same code path deals with the initial load as deals with applying filters as well as on-demand reloading later.

A long time ago with fewer packages this "reload everything" was probably seemingly instant, but with thousands of packages as you have observed it is no longer instant.

The interplay between the model and the UI could be improved to avoid the refresh. It would require some further investigation to find a good refactoring approach.

[waddlesplash]

Following hrev54192 this is considerably improved; see what you think.

[diver]

hrev54195 x86_64. Same ~15 seconds.

[apl-haiku]

I've spent some time on this today and have made some good progress -- it seems to be going much much faster locally. I will do some work on it and hopefully get a PR in the next week.

[diver]

Nice! Looking forward to it :)

[apl-haiku]

Resolved in; ​https://review.haiku-os.org/c/haiku/+/2748