Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16077 closed bug (fixed)

Thai text are not displayed at all

Reported by: bitigchi Owned by: stippi
Priority: critical Milestone: R1/beta2
Component: User Interface Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

See title and screenshot. Missing Thai font.

Attachments (3)

VirtualBox_Haiku_19_05_2020_10_53_32.png (28.9 KB ) - added by bitigchi 4 years ago.
screenshot
ss1.png (121.7 KB ) - added by bitigchi 4 years ago.
screenshot1
ss2.png (140.6 KB ) - added by bitigchi 4 years ago.
screenshot2

Download all attachments as: .zip

Change History (17)

by bitigchi, 4 years ago

screenshot

comment:1 by nephele, 4 years ago

Looks like the font is in noto_regional, "Noto Sans Thai"
There is no fallback at all in app_server for fonts in Noto Regional so that explains no chars, you can try those chars in font demo if you have Noto Sans Thai selected, or if you select that font in StyledEdit.

I am not sure how to proeed, potentially the entire list of regional noto fonts could be in the app_server fallback list, which raises the question if that should be de-hardcoded and noto-regional just adds to it (and e.g a "klingon font" aswell, etc.)

(relevant code https://git.haiku-os.org/haiku/tree/src/servers/app/font/GlyphLayoutEngine.h#n326 )

It looks like Thai is enabled in beta2 FirstBootPrompt (didn't try installer but running system), so this may pose a problem.

comment:2 by nephele, 4 years ago

Seems that code would be fine with adding non-existant fonts to the list, so potentially I could just add Noto Sans Thai as an item (And maybe it should be split out so the installation does not need the entire noto_regional package)

by bitigchi, 4 years ago

Attachment: ss1.png added

screenshot1

by bitigchi, 4 years ago

Attachment: ss2.png added

screenshot2

comment:3 by bitigchi, 4 years ago

It looks like even with fonts installed, it does not display at all. See screenshots.

Edit: On StyledEdit with font selected, letters display.

Last edited 4 years ago by bitigchi (previous) (diff)

comment:4 by nielx, 4 years ago

Milestone: UnscheduledR1/beta2
Priority: normalcritical

Moving to R1beta2 and upgrading it to critical (for the moment), as this needs to be discussed whether we can ship the beta without supporting the Thai translation properly.

comment:5 by nielx, 4 years ago

So what I don't understand yet is whether the Thai fonts are currently included or not.

comment:6 by pulkomandy, 4 years ago

I will look into this during this weekend (which starts tomorrow for me). I don't know if the font will be enough, as this may also need some changes to the font rendering code to properly assemble the letters together. If that's the case I'm not sure it can be done in time for beta2, but we'll see.

comment:7 by bitigchi, 4 years ago

No, they are not included – yet. Still, a patch is needed to get the font system working.

Plus a review from a Thai speaker, whether everything is rendering okay or not.

comment:8 by pulkomandy, 4 years ago

Useful reference on the rendering: https://linux.thai.net/~thep/thaisupp/

I think at least the shaping and the word-breaking will be problematic. But we'll see what happens.

comment:9 by diver, 4 years ago

I wonder what happens with the scrollbar here?

in reply to:  3 comment:10 by pulkomandy, 4 years ago

Replying to bitigchi:

It looks like even with fonts installed, it does not display at all. See screenshots.

Edit: On StyledEdit with font selected, letters display.

Yes, this does not work "magically", the font overlay "system" (or hack, I should say) has to be adjusted.

in reply to:  8 comment:11 by sompon, 4 years ago

Replying to pulkomandy:

Useful reference on the rendering: https://linux.thai.net/~thep/thaisupp/

I think at least the shaping and the word-breaking will be problematic. But we'll see what happens.

I am a native Thai, and I can read what you have shown.

Last edited 4 years ago by sompon (previous) (diff)

comment:12 by waddlesplash, 4 years ago

Resolution: fixed
Status: newclosed

Fixed in hrev54241.

comment:13 by nielx, 4 years ago

Is it fixed? A recent build of the R1Beta2 branch still shows emptiness when I select Thai in FirstBootPrompt. If I understand correctly to really fix this, we should also provide the font.

comment:14 by pulkomandy, 4 years ago

Yes, I have updated the Noto package to include the font, but the copy of it that's shipped with the image is not updated yet. We need to update it and then it will work.

Note: See TracTickets for help on using tickets.