Input preferences crash when adjusting touchpad settings

[tatoomi]

since Hrev 54326 the touchpad utility is back -Thank you- But as soon as you want to adjust the utility 'input "crash

[tatoomi]

Report

[eml]

I'm looking into this ticket and would like to be assigned to prevent duplicate work. I can see why it crashes: InputTouchpadPref.h the class has a BInputDevice pointer called fTouchPad, this in turn is called in InputTouchpadPref.cpp but from what I can tell this will always be a nullpointer, as no value is ever set.

I'm trying to figure out how to set it, pointers are welcome :-)

[pulkomandy]

The device is passed to the constructor here:

​https://git.haiku-os.org/haiku/tree/src/preferences/input/InputWindow.cpp#n184

But the constructor does not do anything with it:

​https://git.haiku-os.org/haiku/tree/src/preferences/input/InputTouchpadPrefView.cpp#n267

[eml]

What a miss... I keep misreading the code for this application. Thank you! I see this is assigned to PreetpalKaur, but I hope it's okay by him that I'm looking at it. If nothing else it lets me dig into more code and feel some sort of success.

[pulkomandy]

Yes, she is the default owner of tickets on Input preferences as the main author of it. The ticket is not marked in-progress so it's fine to work on it.

[eml]

Funnily, you already have a fix for it here: ​https://review.haiku-os.org/c/haiku/+/1590 :)

Gerrit made me aware of that so I abandoned my patch (also you did it better anyhow.) I could extract your changes for the crash into a patch specifically for this ticket, perhaps? That way the bug gets fixed without introducing new features.