Crash while changing ControlLook/Decorator

[bitigchi]

Crash report attached.

[bitigchi]

crash report

[jackburton]

I think that commit b46615c55ad2c8fe6de54412055a0713da3d610a could be the culprit.

Shouldn't every reply start with StartMessage() ? In the app server, file ServerApp.cpp, lines starting from 663:

case AS_SET_DECORATOR:
{
	// Attached Data:
	// path to decorator add-on

	BString path;
	link.ReadString(path);

	status_t error = gDecorManager.SetDecorator(path, fDesktop);

	fLink.Attach<status_t>(error);
	fLink.Flush();

	if (error == B_OK)
		fDesktop->BroadcastToAllApps(AS_UPDATE_DECORATOR);
	break;

I think it's missing the fLink.StartMessage(error)

[jackburton]

I mean:

diff --git a/src/servers/app/ServerApp.cpp b/src/servers/app/ServerApp.cpp index 198dc2fb87..660413f437 100644 --- a/src/servers/app/ServerApp.cpp +++ b/src/servers/app/ServerApp.cpp @@ -670,6 +670,7 @@ ServerApp::_DispatchMessage(int32 code, BPrivate::LinkReceiver& link)

status_t error = gDecorManager.SetDecorator(path, fDesktop);

+ fLink.StartMessage(error);

fLink.Attach<status_t>(error); fLink.Flush();